The default bug view has changed. See this FAQ.

Make Quickfilter bar toggle work for glodaList tabs

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

11 Branch
Thunderbird 13.0
x86
All

Thunderbird Tracking Flags

(thunderbird11+ fixed, thunderbird12 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Steps to reproduce (assumes < TB 11, or patch for bug 728309 is applied, to show mail-bar3 in glodaList tabs)

1)  Type a search query into the Gloda search input
2)  In the results tab, click on one of the results

What happens?

The Quickfilter bar toggle is disabled

What is expected?

The Quickfilter bar toggle should be enabled
Blocks: 728309
Created attachment 599259 [details] [diff] [review]
Patch v1

The onMakeActive function was being fired *before* onTabOpened, and so the QuickFilterState object was not being assigned to _ext.quickFilter in time to enable the toggle in onMakeActive.

I've isolated the logic that enables / disables the Quickfilter toggle, and we now fire it again after the tab has been opened.
Assignee: nobody → mconley
Attachment #599259 - Flags: review?(bwinton)
Comment on attachment 599259 [details] [diff] [review]
Patch v1

Cancelling review request - just noticed some bad stuff got in there (some vars got renamed in onMakeActive that probably shouldn't have).  Fix forthcoming...
Attachment #599259 - Flags: review?(bwinton)
Created attachment 599262 [details] [diff] [review]
Patch v2

Whoops - a last minute change to that patch accidentally caused some variables to be renamed.
Attachment #599259 - Attachment is obsolete: true
Attachment #599262 - Flags: review?(bwinton)
Comment on attachment 599262 [details] [diff] [review]
Patch v2

I ran into a strange bug going to the message view, but I think you're on it.  Aside from that, I like the code, so provisional r=me.  ;)
Attachment #599262 - Flags: review?(bwinton) → review+
Created attachment 599276 [details] [diff] [review]
Patch v3 (r+'d by bwinton)

Thanks for finding that bug, Blake.  I think I've fixed it with this latest patch.  Give 'er a spin, and see what you think.
Attachment #599262 - Attachment is obsolete: true
Comment on attachment 599276 [details] [diff] [review]
Patch v3 (r+'d by bwinton)

Yep, that's the stuff!  :)

Thanks,
Blake.
Attachment #599276 - Flags: review+
Comment on attachment 599276 [details] [diff] [review]
Patch v3 (r+'d by bwinton)

We want this for TB 11 as required by bug 728309
Attachment #599276 - Flags: approval-comm-beta?
Attachment #599276 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/dff1e1822d5b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Attachment #599276 - Flags: approval-comm-beta?
Attachment #599276 - Flags: approval-comm-beta+
Attachment #599276 - Flags: approval-comm-aurora?
Attachment #599276 - Flags: approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/240d12a4dbe2
status-thunderbird12: --- → fixed
tracking-thunderbird11: --- → ?
Created attachment 599447 [details] [diff] [review]
Backport for comm-beta

Backport of attachment 599276 [details] [diff] [review] for comm-beta.  Carrying forward r+/a+.
Landed backport (attachment 599447 [details] [diff] [review]) on comm-beta as http://hg.mozilla.org/releases/comm-beta/rev/52d70cf70e06
status-thunderbird11: --- → fixed
tracking-thunderbird11: ? → +
You need to log in before you can comment on or make changes to this bug.