Closed Bug 729197 Opened 8 years ago Closed 8 years ago

Make Quickfilter bar toggle work for glodaList tabs


(Thunderbird :: Mail Window Front End, defect)

11 Branch
Not set


(thunderbird11+ fixed, thunderbird12 fixed)

Thunderbird 13.0
Tracking Status
thunderbird11 + fixed
thunderbird12 --- fixed


(Reporter: mconley, Assigned: mconley)




(2 files, 2 obsolete files)

Steps to reproduce (assumes < TB 11, or patch for bug 728309 is applied, to show mail-bar3 in glodaList tabs)

1)  Type a search query into the Gloda search input
2)  In the results tab, click on one of the results

What happens?

The Quickfilter bar toggle is disabled

What is expected?

The Quickfilter bar toggle should be enabled
Attached patch Patch v1 (obsolete) — Splinter Review
The onMakeActive function was being fired *before* onTabOpened, and so the QuickFilterState object was not being assigned to _ext.quickFilter in time to enable the toggle in onMakeActive.

I've isolated the logic that enables / disables the Quickfilter toggle, and we now fire it again after the tab has been opened.
Assignee: nobody → mconley
Attachment #599259 - Flags: review?(bwinton)
Comment on attachment 599259 [details] [diff] [review]
Patch v1

Cancelling review request - just noticed some bad stuff got in there (some vars got renamed in onMakeActive that probably shouldn't have).  Fix forthcoming...
Attachment #599259 - Flags: review?(bwinton)
Attached patch Patch v2 (obsolete) — Splinter Review
Whoops - a last minute change to that patch accidentally caused some variables to be renamed.
Attachment #599259 - Attachment is obsolete: true
Comment on attachment 599262 [details] [diff] [review]
Patch v2

I ran into a strange bug going to the message view, but I think you're on it.  Aside from that, I like the code, so provisional r=me.  ;)
Attachment #599262 - Flags: review?(bwinton) → review+
Thanks for finding that bug, Blake.  I think I've fixed it with this latest patch.  Give 'er a spin, and see what you think.
Attachment #599262 - Attachment is obsolete: true
Comment on attachment 599276 [details] [diff] [review]
Patch v3 (r+'d by bwinton)

Yep, that's the stuff!  :)

Attachment #599276 - Flags: review+
Comment on attachment 599276 [details] [diff] [review]
Patch v3 (r+'d by bwinton)

We want this for TB 11 as required by bug 728309
Attachment #599276 - Flags: approval-comm-beta?
Attachment #599276 - Flags: approval-comm-aurora?
Committed to comm-central as
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Attachment #599276 - Flags: approval-comm-beta?
Attachment #599276 - Flags: approval-comm-beta+
Attachment #599276 - Flags: approval-comm-aurora?
Attachment #599276 - Flags: approval-comm-aurora+
Backport of attachment 599276 [details] [diff] [review] for comm-beta.  Carrying forward r+/a+.
You need to log in before you can comment on or make changes to this bug.