Last Comment Bug 729197 - Make Quickfilter bar toggle work for glodaList tabs
: Make Quickfilter bar toggle work for glodaList tabs
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: 11 Branch
: x86 All
: -- normal (vote)
: Thunderbird 13.0
Assigned To: Mike Conley (:mconley) - (Needinfo me!)
:
Mentors:
Depends on:
Blocks: 728309
  Show dependency treegraph
 
Reported: 2012-02-21 10:40 PST by Mike Conley (:mconley) - (Needinfo me!)
Modified: 2012-02-23 06:44 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed
fixed


Attachments
Patch v1 (3.67 KB, patch)
2012-02-21 10:45 PST, Mike Conley (:mconley) - (Needinfo me!)
no flags Details | Diff | Splinter Review
Patch v2 (3.58 KB, patch)
2012-02-21 10:50 PST, Mike Conley (:mconley) - (Needinfo me!)
bwinton: review+
Details | Diff | Splinter Review
Patch v3 (r+'d by bwinton) (3.65 KB, patch)
2012-02-21 11:23 PST, Mike Conley (:mconley) - (Needinfo me!)
bwinton: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review
Backport for comm-beta (3.71 KB, patch)
2012-02-21 18:40 PST, Mike Conley (:mconley) - (Needinfo me!)
no flags Details | Diff | Splinter Review

Description Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 10:40:32 PST
Steps to reproduce (assumes < TB 11, or patch for bug 728309 is applied, to show mail-bar3 in glodaList tabs)

1)  Type a search query into the Gloda search input
2)  In the results tab, click on one of the results

What happens?

The Quickfilter bar toggle is disabled

What is expected?

The Quickfilter bar toggle should be enabled
Comment 1 Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 10:45:51 PST
Created attachment 599259 [details] [diff] [review]
Patch v1

The onMakeActive function was being fired *before* onTabOpened, and so the QuickFilterState object was not being assigned to _ext.quickFilter in time to enable the toggle in onMakeActive.

I've isolated the logic that enables / disables the Quickfilter toggle, and we now fire it again after the tab has been opened.
Comment 2 Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 10:49:05 PST
Comment on attachment 599259 [details] [diff] [review]
Patch v1

Cancelling review request - just noticed some bad stuff got in there (some vars got renamed in onMakeActive that probably shouldn't have).  Fix forthcoming...
Comment 3 Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 10:50:41 PST
Created attachment 599262 [details] [diff] [review]
Patch v2

Whoops - a last minute change to that patch accidentally caused some variables to be renamed.
Comment 4 Blake Winton (:bwinton) (:☕️) 2012-02-21 11:22:16 PST
Comment on attachment 599262 [details] [diff] [review]
Patch v2

I ran into a strange bug going to the message view, but I think you're on it.  Aside from that, I like the code, so provisional r=me.  ;)
Comment 5 Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 11:23:39 PST
Created attachment 599276 [details] [diff] [review]
Patch v3 (r+'d by bwinton)

Thanks for finding that bug, Blake.  I think I've fixed it with this latest patch.  Give 'er a spin, and see what you think.
Comment 6 Blake Winton (:bwinton) (:☕️) 2012-02-21 11:27:46 PST
Comment on attachment 599276 [details] [diff] [review]
Patch v3 (r+'d by bwinton)

Yep, that's the stuff!  :)

Thanks,
Blake.
Comment 7 Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 11:28:59 PST
Comment on attachment 599276 [details] [diff] [review]
Patch v3 (r+'d by bwinton)

We want this for TB 11 as required by bug 728309
Comment 8 Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 12:11:31 PST
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/dff1e1822d5b
Comment 9 Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 14:40:25 PST
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/240d12a4dbe2
Comment 10 Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 18:40:58 PST
Created attachment 599447 [details] [diff] [review]
Backport for comm-beta

Backport of attachment 599276 [details] [diff] [review] for comm-beta.  Carrying forward r+/a+.
Comment 11 Mike Conley (:mconley) - (Needinfo me!) 2012-02-21 18:57:21 PST
Landed backport (attachment 599447 [details] [diff] [review]) on comm-beta as http://hg.mozilla.org/releases/comm-beta/rev/52d70cf70e06

Note You need to log in before you can comment on or make changes to this bug.