729244 - ESC doesn't revert the location bar value anymore

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Dão Gottwald [:dao]]

STR:
- type something in the location bar
- hit ESC

expected: the current page's address should be restored

actual result: nothing happens

Comment 1

[Thomas Ahlblom]

Last good nightly: 2012-02-17
First bad nightly: 2012-02-18

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2271cb92cc05&tochange=550779e6bab4

Comment 2

[Thomas Ahlblom]

The first bad revision is:
changeset:   87042:f01f200f798a
user:        Felix Fung <[e-mail]>
date:        Thu Feb 16 14:56:06 2012 -0500
summary:     Bug 495277 - Reduce calls to new Function in Autocomplete.xml. r=gavin

https://hg.mozilla.org/mozilla-central/rev/f01f200f798a

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Hmm, that's odd. Calling gURLBar.onTextReverted() manually still works fine, but the call from the autocomplete controller doesn't seem to work.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[Dão Gottwald [:dao]]

(In reply to Thomas Ahlblom from comment #2)
> The first bad revision is:
> changeset:   87042:f01f200f798a

Thanks!

Comment 6

[:Gavin Sharp [email: [e-mail]]]

We should get test coverage for this as well.

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6cbae3d86fb4

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/6cbae3d86fb4