Closed Bug 729269 Opened 11 years ago Closed 11 years ago

several sms interfaces shouldn't be marked [function]

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
3.02 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
These all implement multiple methods, so coercion from a JS function to an interface would be...messy.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #599317 -
        Flags: review?(mounir)

        Attachment #599317 -
        Flags: review?(mounir) → review+

    
  
Whiteboard: [autoland-try:-b do -p all -u all -t none]

    
  
Whiteboard: [autoland-try:-b do -p all -u all -t none] → [autoland-in-queue]

    
    

    
  
Autoland Patchset:
	Patches: 599317
	Branch: mozilla-central => try
Error applying patch 599317 to mozilla-central.
patching file dom/sms/interfaces/nsISmsDatabaseService.idl
Hunk #1 FAILED at 39
1 out of 1 hunks FAILED -- saving rejects to file dom/sms/interfaces/nsISmsDatabaseService.idl.rej
abort: patch failed to apply

Could not apply and push patchset:

    
  
Whiteboard: [autoland-in-queue]

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
UUID collision.  Carrying over r+.

        Attachment #599317 -
        Attachment is obsolete: true

        Attachment #600412 -
        Flags: review+

    
  
Whiteboard: [autoland-try:-b do -p all -u all -t none]

    
  
Whiteboard: [autoland-try:-b do -p all -u all -t none] → [autoland-in-queue]

    
    

    
  
Autoland Patchset:
	Patches: 600412
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=cab6a58bde87
Try run started, revision cab6a58bde87. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=cab6a58bde87

    
    

    
  
Try run for cab6a58bde87 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=cab6a58bde87
Results (out of 216 total builds):
    success: 173
    warnings: 28
    failure: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-cab6a58bde87

    
  
Whiteboard: [autoland-in-queue]

    
  
Status: NEW → ASSIGNED
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/bfb774043795
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.