729272 - WebGL initialization should abandon ANGLE if it cannot retrieve d3d share handles

Status: RESOLVED INVALID

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

We hit a huge regression in bug 726396 where suddenly we were not able to get d3d share handles from ANGLE's GLContext. Rendering this way is basically pathological and should not be used. Besides, ANGLE should always provide these, I believe.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Abandon ANGLE during WebGL init if we can't get d3d share handles

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 599322 [details] [diff] [review]
Abandon ANGLE during WebGL init if we can't get d3d share handles

Review of attachment 599322 [details] [diff] [review]:
-----------------------------------------------------------------

I'm trying to see if bugzilla will let me r+ this twice.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Abandon ANGLE during WebGL init if we can't get d3d share handles

Tragically, I typo'd 'IsANGLE()' as 'IsAngle()', so here's the fixed version.

Carrying forward r+.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 599353 [details] [diff] [review]
Abandon ANGLE during WebGL init if we can't get d3d share handles

Attempt to carry forward the double r+.

Comment 5

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5311f051974e

Comment 6

[Daniel Holbert [:dholbert]]

Backed out, on suspicion of causing webgl conformance test failures:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/1e3583bc4dc3

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 599353 [details] [diff] [review]
Abandon ANGLE during WebGL init if we can't get d3d share handles

ANGLE doesn't appear to give out d3d share handles on WinXP (try) machines. This has never been a problem in the past, as d3d9 layers never used the share handles, but it does mean that this patch is not valid.

Ideally, we find out what's wrong with WinXP and ANGLE giving out share handles.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to Jeff Gilbert [:jgilbert] from comment #7)
> Comment on attachment 599353 [details] [diff] [review]
> Abandon ANGLE during WebGL init if we can't get d3d share handles
> 
> ANGLE doesn't appear to give out d3d share handles on WinXP (try) machines.
> This has never been a problem in the past, as d3d9 layers never used the
> share handles, but it does mean that this patch is not valid.
> 
> Ideally, we find out what's wrong with WinXP and ANGLE giving out share
> handles.

ANGLE can't ever give out share handles on WinXP -- D3D share handles are only supported on Vista and above.  On XP, our only option for "fast" WebGL is something like nvidia's direct D3D-GL sharing (or switching to the GL compositor, I guess).

Comment 9

[Kelsey Gilbert [:jgilbert]]

As Vlad mentioned, D3D share handles are only available from D3D9Ex+, but not from XP's D3D9 non-Ex.

Once we have d3d-gl interop, we'll want to fall back to that if ANGLE share handles aren't present, but that's another bug.