Allow public access (in C++) to loaded scripts of a Domain object

RESOLVED FIXED

Status

Tamarin
Library
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: William Maddox, Assigned: pnkfelix)

Tracking

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Created attachment 599394 [details] [diff] [review]
Provide public accessor for m_loadedScripts field.

Allow access to the table of loaded scripts for a Domain object.
Access provided at the C++ level, for the benefit of host-provided native libraries only.

Patch proposed by Xing Zhang <xzhang@adobe.com>.
(Reporter)

Comment 1

6 years ago
I'd recommend renaming the accessor to Domain::getLoadedScripts(), following the nomenclature for the data member.

The patch is trivial, except for possible GC hygiene issues.  Asking Felix to take a look at it.
Assignee: nobody → fklockii
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Attachment #599394 - Attachment is patch: true
Looks fine with me.
(Assignee)

Updated

6 years ago
Attachment #599394 - Flags: review+
(reassigning to Xing since I think he will be renaming the accessor.)
Assignee: fklockii → xzhang

Comment 4

6 years ago
Created attachment 599414 [details] [diff] [review]
change the accessor name to getLoadedScripts

change the accessor name to getLoadedScripts according to previous review
Attachment #599414 - Flags: review?(fklockii)

Comment 5

6 years ago
Name change is done, assign it to Felix for review.
Assignee: xzhang → fklockii
(Assignee)

Updated

6 years ago
Attachment #599414 - Flags: review?(fklockii) → review+
(The diff wasn't in the appropriate format for patching tamarin-redux, but its a trivial patch so that did not hold me up from reviewing nor will it hold me up from landing it.)
((also there were tabs introduced by both patches.  I am not sure why I did not notice that earlier.  Again, easily fixed and I'll just do it before I land it.))
Created attachment 599503 [details] [diff] [review]
Provide public accessor for m_loadedScripts field (v3 final).
Attachment #599394 - Attachment is obsolete: true
Attachment #599414 - Attachment is obsolete: true
Attachment #599503 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #599503 - Attachment description: Provide public accessor for m_loadedScripts field. → Provide public accessor for m_loadedScripts field (v3 final).

Comment 9

6 years ago
changeset: 7212:98ddf7c038a8
user:      Xing Zhang <xzhang@adobe.com>
summary:   Bug 729346: Provide public accessor for m_loadedScripts field. (p=xzhang, r=wmaddox, fklockii).

http://hg.mozilla.org/tamarin-redux/rev/98ddf7c038a8
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.