Clean up Python code to make check.py happy

VERIFIED FIXED in 2.5

Status

VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: adrian, Assigned: adrian)

Tracking

Dependency tree / graph

Details

(Assignee)

Description

7 years ago
Running check.py on recent middleware code (which is suppose to be valid) raises a bunch of errors, from useless imports to various styling errors. We want to have a code that is as clean as possible in recent parts of Socorro, following PEP8 and giving check.py a beautiful, empty output. 

Folders that need clean up:
> socorro/middleware/
> socorro/external/
> socorro/lib/ (not all files)
> socorro/unittest/middleware/
> socorro/unittest/external/
> socorro/unittest/lib/ (not all files)
(Assignee)

Updated

7 years ago
Depends on: 729359
(Assignee)

Updated

7 years ago
Target Milestone: 2.5 → 2.5.1
(Assignee)

Updated

7 years ago
Depends on: 730284
(Assignee)

Comment 1

7 years ago
r=lonnen,peterbe merged
commit=https://github.com/AdrianGaudebert/socorro/commit/f1428ad1e68a93270fed65ba6c94540b2dc68938
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

7 years ago
Steps to QA
-----------

1. Verify that nothing breaks. Once again this is a no-feature-change bug.
(Assignee)

Updated

7 years ago
Target Milestone: 2.5.1 → 2.5

Comment 3

7 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/754ea9d77e1d5e7900f8555de5f58fdf725aef80
Fixes bug 729358 - Cleaned code up for check.py.

https://github.com/mozilla/socorro/commit/720b7f3abec77119523b472ba15b2095429a3c3a
Merge pull request #397 from AdrianGaudebert/729358-clean-up-code-for-check-py

Fixes bug 729358 - Cleaned code up for check.py.

Comment 4

7 years ago
Commits pushed to jberkus-master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f1428ad1e68a93270fed65ba6c94540b2dc68938
Fixes bug 729358 - Cleaned code up for check.py.

https://github.com/mozilla/socorro/commit/27b5cc255d6f028aa957a66abe4f8ec8315d6048
Merge pull request #387 from AdrianGaudebert/729358-clean-up-code-for-check-py

Fixes bug 729358 - Cleaned code up for check.py.
:adrian - verifying nothing breaks (comment 2) is a tall task given this is landing with a bunch of other features and defect fixes. 

Bumping to QA verified, nothing obvius is being earmarked by our automation. We'll open up individual boogs as we come across them.
Status: RESOLVED → VERIFIED

Comment 6

7 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c41274bc48203850ed8a9481db74a45060111263
Fixes bug 729358 - Cleaned code up for check.py.

https://github.com/mozilla/socorro/commit/64a85f2e679f7266adb7bb88619f20cd72db09b9
Merge pull request #417 from AdrianGaudebert/reinject-code-cleaning

Fixes bug 729358 - Cleaned code up for check.py.

Updated

7 years ago
Status: VERIFIED → RESOLVED
Last Resolved: 7 years ago7 years ago
(Assignee)

Comment 7

7 years ago
The commit containing my work on this was once again missing on master... Just added it via https://github.com/mozilla/socorro/pull/417

Sorry about that.
Thanks :adrian, :lonnen filled me in on the goof up where the code was backed out. Bumping back to verified - see comment 5
Status: RESOLVED → VERIFIED
Product: Socorro → Socorro Graveyard
You need to log in before you can comment on or make changes to this bug.