729367 - Add additional JSCLASS_IMPLEMENTS_BARRIERS flags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

We're still disabling write barriers in cases where we shouldn't.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: shell workers patch

Shell workers don't have the JSCLASS_IMPLEMENTS_BARRIERS, but that's because they don't implement write barriers. However, if we leave off the flag, then incremental GC will be disabled when we initialize workers at shell startup.

I hacked around this by putting the flag on, but immediately disabling incremental GC if workers are ever used.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix NPAPI

I also forgot to put the flag on some NPAPI code. I audited this code a while ago, and it didn't need any barriers.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05af8fc6c379
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a49c1500abd

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/1a49c1500abd
https://hg.mozilla.org/mozilla-central/rev/05af8fc6c379