Closed Bug 729373 Opened 8 years ago Closed 8 years ago

Cannot move focus outside of LayerView

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 13

People

(Reporter: eeejay, Assigned: eeejay)

Details

(Whiteboard: [QA+])

Attachments

(1 file)

When focus is in the content, the arrow keys scroll the view and don't allow focusing the top chrome.
Whiteboard: [QA+]
Attachment #599430 - Flags: review?(doug.turner) → review?(bnicholson)
Attachment #599430 - Flags: review?(bnicholson) → review?(cpeterson)
@eeejay, is this an accessibility feature? If the user scrolls up and focuses the browser toolbar, how do they escape back to the content?
(In reply to Chris Peterson (:cpeterson) from comment #2)
> @eeejay, is this an accessibility feature?

Yes, for keyboard-only navigation, otherwise the user needs to focus by touch.

> If the user scrolls up and focuses the browser toolbar, how do they escape back to the content?

By scrolling down again into the LayerView.
>> If the user scrolls up and focuses the browser toolbar, how do they escape back to the 
>> content?
>
> By scrolling down again into the LayerView.

Is the scrolling down into the LayerView already handled in core code? Your patch only adds the cmd_linePrevious/cmd_scrollPageUp handler.
(In reply to Chris Peterson (:cpeterson) from comment #4)
> Is the scrolling down into the LayerView already handled in core code? Your
> patch only adds the cmd_linePrevious/cmd_scrollPageUp handler.

Scrolling in a misnomer here, sorry. The use of the hardware directional controller/d-pad/arrow keys is what I mean. Android interfaces are generally navigable with the d-pad[1], most view classes implement this right. The problem with the LayerView is that it traps the directional control keys and uses them for scrolling, which is fine because it should be seen as a container widget. But it needs to blur when the user presses "up" when there is nowhere else to scroll.

1. http://developer.android.com/guide/practices/design/accessibility.html#Navigation
Comment on attachment 599430 [details] [diff] [review]
Move focus to chrome when overscrolling up with keyboard

LGTM. Thanks!
Attachment #599430 - Flags: review?(cpeterson) → review+
Thanks for the speedy review. So [QA+] in the whiteboard mean QA needs to test this patch before I commit?
aaronmt, what does "[QA+]" mean?
Juts means that qa to verify the bug and write any test cases for this issue. Not what is suggested in comment 7.
Agreed! This needs QA coverage.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dc073cdc3e28
Assignee: nobody → eitan
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.