Closed Bug 729382 Opened 9 years ago Closed 9 years ago

move the rest of the CallObject stuff into ScopeObject.cpp

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file)

Attached patch mvSplinter Review
Missed this in the initial ScopeObject patch.  Keeps annoying me.  Patch just moves/renames stuff, no semantic changes.
Attachment #599440 - Flags: review?(jwalden+bmo)
Comment on attachment 599440 [details] [diff] [review]
mv

Review of attachment 599440 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't look at the jsfun.cpp/ScopeObject.cpp bits, assuming they're entirely copypasta.

::: js/src/vm/ScopeObject.h
@@ +165,5 @@
>      inline void copyValues(uintN nargs, Value *argv, uintN nvars, Value *slots);
> +
> +    static JSBool getArgumentsOp(JSContext *cx, JSObject *obj, jsid id, Value *vp);
> +    static JSBool setArgumentsOp(JSContext *cx, JSObject *obj, jsid id, JSBool strict, Value *vp);
> +    static JSBool getArgOp(JSContext *cx, JSObject *obj, jsid id, js::Value *vp);

Kill the js:: in this and the other signatures.
Attachment #599440 - Flags: review?(jwalden+bmo) → review+
...modulo renaming of course.
https://hg.mozilla.org/mozilla-central/rev/d485f2378abe
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.