Do periodic PGO on services-central

RESOLVED FIXED

Status

Release Engineering
General
P2
major
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This time, we got lucky: rather than it being the never-tested-by-PGO merge from services-central, the PGO bustage on mozilla-central was from something else pushed directly there.

Next time? Probably won't be so lucky.

Anything which merges to mozilla-central needs to do periodic PGO (along with every other visible thing on m-c).
(Assignee)

Comment 1

6 years ago
Created attachment 599512 [details] [diff] [review]
fix

Sure hope someone's counting builders on their fingers, so they'll know when we're about to hit the limit again.
Attachment #599512 - Flags: review?(catlee)
(Assignee)

Comment 2

6 years ago
Comment on attachment 599512 [details] [diff] [review]
fix

Oh, no wonder this hadn't taken effect yet - I made a bad choice of reviewer, and haven't even landed it yet.
Attachment #599512 - Flags: review?(catlee) → review?(jhford)
Comment on attachment 599512 [details] [diff] [review]
fix

Review of attachment 599512 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is fine, but we need to be careful not to have periodic PGO on too many branches, otherwise we'll end up with too many slaves doing PGO stuff full time.
Attachment #599512 - Flags: review?(jhford) → review+
(Assignee)

Comment 5

6 years ago
(In reply to John Ford [:jhford] from comment #3)
> The patch is fine, but we need to be careful not to have periodic PGO on too
> many branches, otherwise we'll end up with too many slaves doing PGO stuff
> full time.

Yeah, arguably I should have made them per-checkin, and I'll watch how they go and maybe switch them.
This went live this morning in the scheduled reconfiguration.
(Assignee)

Comment 7

6 years ago
Won't actually be visible until the second reconfig writes the builder pickle file, though, so I can see they are running by seeing the tests running and then disappearing, but we won't see anything finished until one more.
(Assignee)

Comment 8

6 years ago
Can't remember which was the second, might have been Tuesday morning.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.