Open
Bug 729472
Opened 13 years ago
Updated 3 years ago
Remove nsHTMLEditUtils::IsContainer
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
NEW
People
(Reporter: Ms2ger, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
7.59 KB,
patch
|
ehsan.akhgari
:
review-
|
Details | Diff | Splinter Review |
|
17.19 KB,
patch
|
ehsan.akhgari
:
review-
|
Details | Diff | Splinter Review |
Rationale in bug 729046; it also simplifies code.
Attachment #599558 -
Flags: review?(ehsan)
|
Reporter | |
Comment 1•13 years ago
|
||
Attachment #599559 -
Flags: review?(ehsan)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 599558 [details] [diff] [review]
Part a: Remove nsHTMLEditUtils::IsContainer
Review of attachment 599558 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not sure if I like this patch in its current state. This moves the container logic from the table in nsHTMLEditUtils.cpp to a random nsHTMLEditor method, which is not an improvement IMO. The rest of the changes look fine though.
Attachment #599558 -
Flags: review?(ehsan) → review-
|
|
||
Updated•13 years ago
|
Attachment #599559 -
Flags: review?(ehsan) → review-
|
|
Reporter | |
Comment 3•13 years ago
|
||
I'm not sure how the table would work in the new world; you can't index them on nsIAtoms, can you?
|
|
||
Comment 4•13 years ago
|
||
(In reply to Ms2ger from comment #3)
> I'm not sure how the table would work in the new world; you can't index them
> on nsIAtoms, can you?
I'm not sure what you mean here.
(Sorry for the delay, I have been way behind my bugmail)
|
|
Reporter | |
Updated•9 years ago
|
Assignee: Ms2ger → nobody
Status: ASSIGNED → NEW
|
||
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•