Closed Bug 729665 Opened 14 years ago Closed 14 years ago

init script killproc is too impatient

Categories

(Socorro :: Infra, task)

Product:
Socorro
Component:
Infra
Platform:
x86_64
Linux
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: lars, Assigned: rhelmer)

Details

(Whiteboard: [qa-])

During the 2.4.3 upgrade, the processors had problems restarting. On investigation, it is found that the old processors aren't cleaning up after themselves. That happens because the init script killproc is impatient and wants a processor to shut down within 5 seconds. That isn't always possible because processors, during an orderly shutdown, complete their current work before cleaning up and quitting. We need to increase the 5 second delay to something greater, 10 seconds would likely be fine. We can be guaranteed that if a processor is killed with SIGKILL, the cleanup was not done and a new processor will have trouble on startup. according to jason: I think we need to add -t flag to https://github.com/mozilla/socorro/blob/master/scripts/init.d/socorro-processor#L45
Target Milestone: 2.5.1 → 2.5.2
Assignee: nobody → rhelmer
Target Milestone: 2.5.2 → 2.5.3
https://github.com/mozilla/socorro/pull/443
Status: NEW → ASSIGNED
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/fdbc8044fbfedfc8c0655ed1b69d3bca6e200c29 Merge pull request #443 from rhelmer/bug729665-init-killproc-too-impatient bug 729665 - make killproc wait 10s instead of the default 5s, to give p...
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Looks like killproc doesn't take a "-t" argument, at least on the version of RHEL on crash-stats-dev (6.1)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/7ae94db8e6ac0272aec85ff9d87f78083cb0ff28 bug 729665 - backout fdbc8044fbfedfc8c0655ed1b69d3bca6e200c29, killproc does not take a -t option on RHEL 6.1 https://github.com/mozilla/socorro/commit/a8f88af3242d3546303ba6a71d997a70abb60eab Merge pull request #450 from rhelmer/bug729665-init-killproc-too-impatient bug 729665 - backout fdbc8044fbfedfc8c0655ed1b69d3bca6e200c29, killproc ...
I took a look at where this is implemented (/etc/rc.d/init.d/functions), looks like the option is "-d" (delay)
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/3b481208b66aacfb192875894aeaa0ef0067dc36 bug 729665 - use RHEL killproc delay option -d instead of -t https://github.com/mozilla/socorro/commit/fa34c39632ae8adcadd40debae39866367c604df Merge pull request #451 from rhelmer/bug729665-init-killproc-too-impatient bug 729665 - use RHEL killproc delay option -d instead of -t
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/6068367a961685c7242856586b88784943aced4c bug 729665 - killproc cares about position of args https://github.com/mozilla/socorro/commit/30e7efe138715f4a35467445087931697e2c3dc0 Merge pull request #452 from rhelmer/bug729665-init-killproc-too-impatient bug 729665 - killproc cares about position of args
Whiteboard: [qa-]
Commits pushed to stage at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/7e44540d3d0807e4335374d2a99a7b4d6e4c42bd bug 729665 - make killproc wait 10s instead of the default 5s, to give processors time to shut down properly https://github.com/mozilla/socorro/commit/995fbc91551b289e12b4c5cacdd6c25053ec6636 bug 729665 - backout fdbc8044fbfedfc8c0655ed1b69d3bca6e200c29, killproc does not take a -t option on RHEL 6.1 https://github.com/mozilla/socorro/commit/fafe848fc32f3abeeefc8a1bbbe86aa630a1ec76 bug 729665 - use RHEL killproc delay option -d instead of -t https://github.com/mozilla/socorro/commit/9e33298dd1dbac09ec2ee644258b578cd80dcc0a bug 729665 - killproc cares about position of args
Commits pushed to https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/7e44540d3d0807e4335374d2a99a7b4d6e4c42bd bug 729665 - make killproc wait 10s instead of the default 5s, to give processors time to shut down properly https://github.com/mozilla/socorro/commit/995fbc91551b289e12b4c5cacdd6c25053ec6636 bug 729665 - backout fdbc8044fbfedfc8c0655ed1b69d3bca6e200c29, killproc does not take a -t option on RHEL 6.1 https://github.com/mozilla/socorro/commit/fafe848fc32f3abeeefc8a1bbbe86aa630a1ec76 bug 729665 - use RHEL killproc delay option -d instead of -t https://github.com/mozilla/socorro/commit/9e33298dd1dbac09ec2ee644258b578cd80dcc0a bug 729665 - killproc cares about position of args
Commits pushed to v3-branch at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/7e44540d3d0807e4335374d2a99a7b4d6e4c42bd bug 729665 - make killproc wait 10s instead of the default 5s, to give processors time to shut down properly https://github.com/mozilla/socorro/commit/995fbc91551b289e12b4c5cacdd6c25053ec6636 bug 729665 - backout fdbc8044fbfedfc8c0655ed1b69d3bca6e200c29, killproc does not take a -t option on RHEL 6.1 https://github.com/mozilla/socorro/commit/fafe848fc32f3abeeefc8a1bbbe86aa630a1ec76 bug 729665 - use RHEL killproc delay option -d instead of -t https://github.com/mozilla/socorro/commit/9e33298dd1dbac09ec2ee644258b578cd80dcc0a bug 729665 - killproc cares about position of args
You need to log in before you can comment on or make changes to this bug.