729674 - Broken calendar-tab-button / task-tab-button on tab toolbar during toolbar customization

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: screenshot of problem

During customization of the tab toolbar some errors can be observed:

The icon on the calendar-tab-button / task-tab-button is broken.
The customize toolbar dialog shows an additional set of icons using the old icon style.
The default buttons cannot be removed from the toolbar.
See attached screenshot for details.

Lightning 1.4a2 (BuildID: 20120222005925) + Thunderbird 12.0a2
Lightning 1.5a1 (BuildID: 20120222040622) + Thunderbird 13.0a1

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Solve the broken buttons

This patch solves the broken buttons on the tabs toolbar.

This two buttons there never removable. They only moved to the new toolbar because the old is deprecated. But now other buttons can be positioned on both sides of this two buttons. This two buttons are also always accessible whith a lot of tabs open and the user wants to go to Calendar/Tasks.

The two additional buttons are also since a long time available and can be put to the mail toolbar. This can be handy when the user uses auto hide the tab bar and the two other buttons aren't accessible.

I hope it's okay for you to review this patch.

Comment 2

[Richard Marti (:Paenglab)]

Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/075071462254>

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 599761 [details] [diff] [review]
Solve the broken buttons

The previous patch is also in aurora. So it makes sense to push this bug also to aurora.

Comment 4

[Jim Porter (:squib)]

(In reply to Richard Marti [:paenglab] from comment #1)
> This two buttons there never removable. They only moved to the new toolbar
> because the old is deprecated.

Wait... do you mean that the Lightning buttons on the tab bar aren't customizable at all? That's wrong, I think.

Comment 5

[Stefan Sitter [:ssitter]]

Thunderbird and SeaMonkey did some effort to make the tabbar customizable. Therefore I expect that Lightning doesn't prevent this customization and allows to remove the buttons. IMHO we need a follow-up bug to make them customizable.

Comment 6

[Richard Marti (:Paenglab)]

This was a decision to quick migrate to the new toolbar. Before this change the same buttons where already irremovable on the tab bar. Lightning has already movable buttons. What, when the two buttons are also removable? Then we could have four buttons in the customize window. This could then irritate the user.

The actual state is no change to before for the user.

Comment 7

[Jim Porter (:squib)]

We should be using the already-existing customizable buttons and putting them on the tab bar toolbar by default when installing/upgrading Lightning. Then we can just remove these other buttons. I'll see about writing a patch in a week or two if no one else gets to it by then.

Comment 8

[Stefan Sitter [:ssitter]]

Filed Bug 730217 for the customization therefore this bug can focus on fixing the broken icons.

Comment 9

[Richard Marti (:Paenglab)]

Pushed to comm-aurora: <http://hg.mozilla.org/releases/comm-aurora/rev/c951cc0c7887>