Selecting/deselecting images is slow




7 years ago
5 years ago


(Reporter: martijn.martijn, Unassigned)


({perf, testcase})

Windows 7
perf, testcase

Firefox Tracking Flags

(Not tracked)



(1 attachment)



7 years ago
Created attachment 599753 [details]

See testcase, click on the "Start select/deselect test" button to start the test.

In Firefox11b, I get as result: 24593ms
On trunk, I get: 17218ms
In Google Chrome, I get: 5142ms.
On Mac, I see us spending almost all our time painting.  

  44% is PaintImage.
  19% is nsDisplaySelectionOverlay::Paint (calling cairo_fill_preserve).  
   6% is building container layers
   8% is building display lists
  15% is the invalidates triggered by the selection/deselection code
On Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120617030532 I get
Time deselecting/selecting took: 7903ms
on Win 7 x86.

On Chrome 21 it's
Time deselecting/selecting took: 4479ms.

Windows 7 Cleopatra Profile:
FWIW, since Comment 2 running Attachment 599753 [details] regressed from ~6s to ~20s (on Win 7/HWA: on):

Last good nightly: 2012-09-28 (Fx 18)
First bad nightly: 2012-09-29 (Fx 19)

Forgot to add recent SPS Profile against Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130811030225 CSet: 3d20597e0a07:
Matt, could this be due to DLBI?
Flags: needinfo?(matt.woodrow)
I don't see us invalidating anything more than necessary here.

I'd guess it's more likely to be high quality image downscaling (Bug 486918).
Flags: needinfo?(matt.woodrow)
Ah, ok. XtC4UaLL, does setting the image.high_quality_downscaling.enabled preference to false help any?
Flags: needinfo?(xtc4uall)
Disabling the Downscaler makes no difference (tried HWA on/off).
Can't you Devs repro the Issue?
If not you might want to provide Win32 Try Builds of e.g. 10279bd74ee0 / b62b229a4d41 to narrow this down further (haven't build locally for months)?
Flags: needinfo?(xtc4uall) → needinfo?(bzbarsky)
I don't have a Windows build available right now to reproduce with...
Flags: needinfo?(bzbarsky)
You need to log in before you can comment on or make changes to this bug.