Selecting/deselecting images is slow

NEW
Unassigned

Status

()

7 years ago
5 years ago

People

(Reporter: martijn.martijn, Unassigned)

Tracking

({perf, testcase})

Trunk
x86
Windows 7
perf, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 599753 [details]
testcase

See testcase, click on the "Start select/deselect test" button to start the test.

In Firefox11b, I get as result: 24593ms
On trunk, I get: 17218ms
In Google Chrome, I get: 5142ms.
On Mac, I see us spending almost all our time painting.  

  44% is PaintImage.
  19% is nsDisplaySelectionOverlay::Paint (calling cairo_fill_preserve).  
   6% is building container layers
   8% is building display lists
  15% is the invalidates triggered by the selection/deselection code
On Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120617030532 I get
Time deselecting/selecting took: 7903ms
on Win 7 x86.

On Chrome 21 it's
Time deselecting/selecting took: 4479ms.

Windows 7 Cleopatra Profile:  http://people.mozilla.com/~bgirard/cleopatra/?report=AMIfv97fvCX92DbZka60z5qjhvctNpwhxtWIPgV7974aFy6fODyJEXwPm3wQOCcUqRgutAE0EuXTG1PhsRHp83Fad4EC7Zo7Y2MSobHMXgUmK8Fbq_zm9XtyTVWBKTZANSpL2i4bXvkojtX2ShtQwDTAdudB2XV7Dw
FWIW, since Comment 2 running Attachment 599753 [details] regressed from ~6s to ~20s (on Win 7/HWA: on):

Last good nightly: 2012-09-28 (Fx 18)
First bad nightly: 2012-09-29 (Fx 19)

Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=895f66c4eada&tochange=c09a0c022b2e
Forgot to add recent SPS Profile against Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130811030225 CSet: 3d20597e0a07:

http://people.mozilla.com/~bgirard/cleopatra/#report=70c0610e94ba81b5c1bb22176113b52e1c3bc2d5
Matt, could this be due to DLBI?
Flags: needinfo?(matt.woodrow)
I don't see us invalidating anything more than necessary here.

I'd guess it's more likely to be high quality image downscaling (Bug 486918).
Flags: needinfo?(matt.woodrow)
Ah, ok. XtC4UaLL, does setting the image.high_quality_downscaling.enabled preference to false help any?
Flags: needinfo?(xtc4uall)
Disabling the Downscaler makes no difference (tried HWA on/off).
Can't you Devs repro the Issue?
If not you might want to provide Win32 Try Builds of e.g. 10279bd74ee0 / b62b229a4d41 to narrow this down further (haven't build locally for months)?
Flags: needinfo?(xtc4uall) → needinfo?(bzbarsky)
I don't have a Windows build available right now to reproduce with...
Flags: needinfo?(bzbarsky)
You need to log in before you can comment on or make changes to this bug.