IonMonkey: MTruncateToInt32 should support constant folding

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mjrosenb, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 599782 [details] [diff] [review]
/home/mrosenberg/patches/foldTruncateToInt-r0.patch

If you have |x & 0xffffffff|, 0xffffffff is encoded as 4294967295.0 (the double), then is converted to -1 (the integer) at runtime, every time the constant is needed.

This speeds up nsieve by 11%, and md5 by 17% (on ARM)
It probably has similar benefits on x86 and x64.
Attachment #599782 - Flags: review?(sstangl)

Updated

5 years ago
Attachment #599782 - Flags: review?(sstangl) → review+
(Reporter)

Comment 1

5 years ago
landed: http://hg.mozilla.org/projects/ionmonkey/rev/3436c259fb42
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.