729730 - Developer Agreement step: missing things from mocks

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/en-US/developers/submit/app/terms
2. Compare it to the mocks at http://people.mozilla.org/~fligtar/marketplace/developer/submission/1%20-%20Agreement.png

The actual pages are missing-

- An (optional) checkbox to grant Mozilla permission to email users about relevant info
- Links to (i) Printable version (ii) Additional Marketplace policies

Comment 1

[Christopher Van Wiemeersch [:cvan]]

(In reply to krupa raj 82[:krupa] from comment #0)
> Created attachment 599785 [details]
> screenshot
> 
> steps to reproduce:
> 1. Load https://marketplace-dev.allizom.org/en-US/developers/submit/app/terms
> 2. Compare it to the mocks at
> http://people.mozilla.org/~fligtar/marketplace/developer/submission/1%20-
> %20Agreement.png
> 
> The actual pages are missing-
> 
> - An (optional) checkbox to grant Mozilla permission to email users about
> relevant info
> - Links to (i) Printable version (ii) Additional Marketplace policies

I'd WONTFIX half of this bug - the part about a newsletter. I don't know what that should be hooked up to.

Comment 2

[Justin Scott [:fligtar]]

Just store the newsletter bit in the db; doesn't need to talk to other services. It's mainly so the UR team can do 1:1 feedback from developers and is important.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/0599b9d

Comment 4

[krupa raj[:krupa]]

this is done