Closed
Bug 729847
Opened 12 years ago
Closed 12 years ago
App icon appears at Step 3 only after page reload
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
VERIFIED
FIXED
6.4.4
People
(Reporter: krupa.mozbugs, Assigned: andy+bugzilla)
References
()
Details
steps to reproduce: 1. Upload a webapp which has a custom icon in its manifest 2. After it passes validation, click 'Continue'. expected behavior: The App icon is extracted and loads at https://marketplace-dev.allizom.org/en-US/developers/submit/app/details/marble-run-29 actual behavior: The custom app icon loads only after a refresh
Comment 1•12 years ago
|
||
https://github.com/mozilla/zamboni/commit/9d34b75 So that the icon extraction can be QA'd, I temporarily fixed this by temporarily removing the `delay` for this celery task. This is temporary until we figure out what's going on with our queues. Don't close this bug until we're certain what's going on.
Assignee | ||
Comment 2•12 years ago
|
||
The icon extraction has been made faster, but its async the extract icon and then the resize and that's the way it should stay ideally. We need polling to see if the icon is there yet, similar to the way we did for the edit pages, we can pull that stuff over. https://github.com/mozilla/zamboni/commit/c97579f
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → thepotch
Comment 3•12 years ago
|
||
Is this related to bug 730309?
Priority: -- → P1
Target Milestone: --- → 6.4.4
Assignee | ||
Comment 4•12 years ago
|
||
The polling is working for me locally now. Trying to repro on -dev, but the celery is too fast there. https://github.com/mozilla/zamboni/commit/673af39
Assignee | ||
Comment 5•12 years ago
|
||
This is a mine field and hard to test, but check out this video: http://screencast.com/t/ImH0e8h1j This webapp is only accessible inside the VPN but delays the icon just enough not to generate an error and slow enough to trigger the polling: http://amckay-papal.khan.mozilla.org/webapps/sample-manifest.webapp Please file anymore issues under a new bug.
Assignee: thepotch → amckay
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•