Avoid linker warnings when starting up on Android

RESOLVED FIXED in mozilla13

Status

()

Core
mozglue
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla13
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The new linker outputs warnings when it sees dynamic entry types it doesn't handle. It was done on purpose to avoid surprises. The entry types that the linker emits warnings for are:
DT_PLTREL, DT_SONAME, DT_SYMBOLIC, DT_RELCOUNT, DT_VERSYM, DT_VERDEF, DT_VERDEFNUM, DT_VERNEED, DT_VERNEEDNUM.

DT_PLTREL can be checked. DT_SONAME could, but it's really not important so we can ignore it. DT_RELCOUNT indicates how many relocations are relative (and thus how many can be skipped when the binary is prelinked), which is useless information for us, and DT_VER* types are for symbol versioning, which is not supported. DT_SYMBOLIC is a flag to modify the way symbols are resolved.

We can make a conscious choice of ignoring them (which, in fact, we currently do), as long as we know why we do.
(Assignee)

Comment 1

6 years ago
Created attachment 599949 [details] [diff] [review]
Avoid linker warnings when starting up on Android
Attachment #599949 - Flags: review?(taras.mozilla)
(Assignee)

Updated

6 years ago
Assignee: nobody → mh+mozilla

Comment 2

6 years ago
Comment on attachment 599949 [details] [diff] [review]
Avoid linker warnings when starting up on Android

might be some value in leaving some of these on in debug builds. your call.
Attachment #599949 - Flags: review?(taras.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/962c92bbed02
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.