Checked QFB button should better work with Personas

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 13.0
x86_64
Mac OS X

Thunderbird Tracking Flags

(thunderbird11 fixed, thunderbird12 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Bug 728553 introduced a pressed state when checked. The button has then a fixed color which could make it bad readable on some Personas.
(Assignee)

Comment 1

5 years ago
Created attachment 600107 [details] [diff] [review]
Patch

Patch inheriting the color and text shadow. Also making the button slightly more transparent.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #600107 - Flags: ui-review?(bwinton)
Attachment #600107 - Flags: review?(bwinton)
(Assignee)

Comment 2

5 years ago
Adding Mark because he saw this first.
(Assignee)

Comment 3

5 years ago
Created attachment 600109 [details]
Comparison. Top before, bottom after patch
Comment on attachment 600107 [details] [diff] [review]
Patch

Seems to look better, and the code is clean.  r=me, ui-r=me.

Thanks,
Blake.
Attachment #600107 - Flags: ui-review?(bwinton)
Attachment #600107 - Flags: ui-review+
Attachment #600107 - Flags: review?(bwinton)
Attachment #600107 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

5 years ago
Comment on attachment 600107 [details] [diff] [review]
Patch

Associated Bug 728553 is also in beta. Then this makes sense to put this also there.
Attachment #600107 - Flags: approval-comm-beta?
Attachment #600107 - Flags: approval-comm-aurora?
Checked in: http://hg.mozilla.org/comm-central/rev/2210f715d6df
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Attachment #600107 - Flags: approval-comm-beta?
Attachment #600107 - Flags: approval-comm-beta+
Attachment #600107 - Flags: approval-comm-aurora?
Attachment #600107 - Flags: approval-comm-aurora+
Landed on branches:

http://hg.mozilla.org/releases/comm-aurora/rev/04fc8f6476e8
http://hg.mozilla.org/releases/comm-beta/rev/2c5307e02f05
status-thunderbird11: --- → fixed
status-thunderbird12: --- → fixed
You need to log in before you can comment on or make changes to this bug.