Closed
Bug 730079
Opened 12 years ago
Closed 12 years ago
Move sCurrentGLContext to TLS to support off main thread GLDebug
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file, 2 obsolete files)
5.62 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #600147 -
Flags: review?
Assignee | ||
Updated•12 years ago
|
Attachment #600147 -
Flags: review? → review?(ajuma)
Comment 1•12 years ago
|
||
Comment on attachment 600147 [details] [diff] [review] patch Review of attachment 600147 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/GLContext.h @@ +1476,5 @@ > GLContextSymbols mSymbols; > > #ifdef DEBUG > + static Monitor sCurrentGLContextMonitor; > + static PRUintn sCurrentGLContextTLS; Add a comment that we're using thread-local storage to track the GL context that's current for this thread.
Attachment #600147 -
Flags: review?(ajuma) → review+
Comment 2•12 years ago
|
||
Can I get a +1 for the future-looking comment/message there ? ;-)
Assignee | ||
Comment 3•12 years ago
|
||
+1 for making me do work: // GLDebugMode will check that we don't send call // to a GLContext that isn't current on the current // thread. // Store the current context when binding to thread local // storage to support DebugMode on an arbitrary thread.
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bf0007285f7
Assignee | ||
Comment 5•12 years ago
|
||
Assignee: nobody → bgirard
Attachment #600147 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #600171 -
Flags: review+
Comment 6•12 years ago
|
||
Backed out for warnings as errors build failures: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0bf0007285f7 https://hg.mozilla.org/integration/mozilla-inbound/rev/9304fda5ddc7
You don't need to lock around access to thread-local storage. It's thread local ;).
Assignee | ||
Comment 8•12 years ago
|
||
I'm looking to initialize the TLS index.
Assignee | ||
Comment 9•12 years ago
|
||
Attachment #600171 -
Attachment is obsolete: true
Attachment #600542 -
Flags: review?(joe)
Updated•12 years ago
|
Attachment #600542 -
Flags: review?(joe) → review+
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/projects/maple/rev/e1763649ed94
Assignee | ||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/30af776a2988
Comment 12•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/30af776a2988
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•