730079 - Move sCurrentGLContext to TLS to support off main thread GLDebug

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 1

[Ali Juma [:ajuma]]

Comment on attachment 600147 [details] [diff] [review]
patch

Review of attachment 600147 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.h
@@ +1476,5 @@
>      GLContextSymbols mSymbols;
>  
>  #ifdef DEBUG
> +    static Monitor sCurrentGLContextMonitor;
> +    static PRUintn sCurrentGLContextTLS;

Add a comment that we're using thread-local storage to track the GL context that's current for this thread.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Can I get a +1 for the future-looking comment/message there ? ;-)

Comment 3

[Benoit Girard (:BenWa)]

+1 for making me do work:

    // GLDebugMode will check that we don't send call
    // to a GLContext that isn't current on the current
    // thread.
    // Store the current context when binding to thread local
    // storage to support DebugMode on an arbitrary thread.

Comment 4

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0bf0007285f7

Comment 5

[Benoit Girard (:BenWa)]

Attachment: patch v2

Comment 6

[Ed Morley [:emorley]]

Backed out for warnings as errors build failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0bf0007285f7

https://hg.mozilla.org/integration/mozilla-inbound/rev/9304fda5ddc7

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

You don't need to lock around access to thread-local storage.  It's thread local ;).

Comment 8

[Benoit Girard (:BenWa)]

I'm looking to initialize the TLS index.

Comment 9

[Benoit Girard (:BenWa)]

Attachment: patch v3

Comment 10

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/projects/maple/rev/e1763649ed94

Comment 11

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30af776a2988

Comment 12

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/30af776a2988