Closed
Bug 730120
Opened 12 years ago
Closed 12 years ago
Language selector doesn't work
Categories
(Websites :: Firefox Flicks, defect)
Websites
Firefox Flicks
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: wenzel, Assigned: wenzel)
References
Details
The language selector dropdown in the footer of Fx Flicks doesn't work: https://firefoxflicks-dev.allizom.org/en-US/ It also lacks a non-JS "go" button. For a working implementation, check out (for example) Firefox Input.
Assignee | ||
Comment 1•12 years ago
|
||
I added JS to auto-submit this thing on selection. https://github.com/mozilla/firefox-flicks/pull/51 Note that I did not add a separate button as a compromise because: - it'd introduce an L10n string - it'd need more styling - the entire rest of the site does not work without JS (BrowserID, for example).
Assignee: nobody → fwenzel
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 2•12 years ago
|
||
BTW, we're going to add a test for this in https://github.com/mozilla/marketing-project-template
Comment 3•12 years ago
|
||
fixed on dev https://firefoxflicks-dev.allizom.org/zh-CN/ https://firefoxflicks-dev.allizom.org/pt-BR/ https://firefoxflicks.allizom.org/en-US/ language selector has only en-US. Please update to pickup code from dev.
Comment 4•12 years ago
|
||
Verified FIXED on prod: https://firefoxflicks.mozilla.org/zh-TW/, etc.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•