Closed Bug 730128 Opened 8 years ago Closed 8 years ago
Remove code ifdef'd MOZ
_WINSDK _TARGETVER for pre-Windows 7 SDKs
+++ This bug was initially created as a clone of Bug #721496 +++ We can also remove |#if MOZ_WINSDK_TARGETVER >= MOZ_NTDDI_WIN7|.
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
This patch (19 files) created a nice clean clobber build on my local system. Note (and comments?) that I left MOZ_NTDDI_WIN7 defined in the (2) configure.in files, and in gfxWindowsPlatform.cpp due to the following code snip: /** * XXX below should be >= MOZ_NTDDI_WIN8 or such which is not defined yet */ #if MOZ_WINSDK_TARGETVER > MOZ_NTDDI_WIN7 #define ENABLE_GPU_MEM_REPORTER #endif
Comment on attachment 600278 [details] [diff] [review] Patch v1 Adding original requester as eventual reviewer.
Comment on attachment 600278 [details] [diff] [review] Patch v1 It looks good while I'm not an official widget/win32 peer.
Comment on attachment 600278 [details] [diff] [review] Patch v1 looks like everything matches up.
Attachment #600278 - Flags: review?(jmathies) → review+
Autoland Patchset: Patches: 600278 Branch: mozilla-central => try Destination: http://hg.mozilla.org/try/pushloghtml?changeset=021c4bac0330 Try run started, revision 021c4bac0330. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=021c4bac0330
Try run for 021c4bac0330 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=021c4bac0330 Results (out of 217 total builds): success: 177 warnings: 24 failure: 16 Builds (or logs if builds failed) available at: http://email@example.com
All WIN build / tests pass, asking to promote.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7db039c3f3e2 Pretty sure I already gave you the speech about attaching mq patches, so I'll skip it this time :)
I'm sorry Ryan, yes you did. This patch was posted before that and didn't include the MQ patch stuff ... I guess I could have obsoleted the patch, re-posted the new one and asked for re-review... Was there an easier way? I have one last patch posted without MQ stuff ... it's passed feedback but not approval and needs more changes anyhow ... it'll have to be obsoleted and re-posted. So... before I move any more patches forward, they will observe the rules.
It's not a problem at all! I figured that was the case and no, definitely not worth spinning up a new patch just for that. Sounds good on the next patch, thanks again for contributing!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.