If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Stacks are not updated when not in stack contents view (default, drawer-state)

RESOLVED FIXED in M2

Status

Pancake
Front-end
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gordonb, Assigned: sfoster)

Tracking

unspecified
x86
Mac OS X

Details

(Reporter)

Description

6 years ago
What happens (drawer-state branch):

1. Enter a stack
2. Launch a place from the stack
3. Click "back" in the stack drawer to display the list of stacks
4. Click on a link in the viewer (creating a new place)
5. (!) Stack count/current site is not updated in list view.
6. Click into stack
7. (!) Stack shows wrong active place. New, truly active place is not displayed.
8. Clicking out of stack shows that list view is updated now with correct count and title.
9. Click back into stack.
10. (!) Stack shows wrong active place. New, truly active place is not displayed.
11. Refresh page.
12. Re-open stack in drawer.
13. Stack is correctly displayed.

What happens (default branch):

1. Enter a stack
2. Launch a place from the stack
3. Click "back" in the stack drawer to display the list of stacks
4. Click on a link in the viewer (creating a new place)
5. (!) Stack count/current site is not updated in list view.
6. Click into stack
7. Stack shows new place as active place.
8. Clicking out of stack shows that list view is updated now with correct count and title.
9. Refresh page.
10. Re-open stack in drawer.
11. Stack is correctly displayed.

What I expect:

1. Enter a stack
2. Launch a place from the stack
3. Click "back" in the stack drawer to display the list of stacks
4. Click on a link in the viewer (creating a new place)
5. Stack count/current site is updated in list view.
6. Click into stack
7. Stack shows new place as active place.
8. Refresh page.
9. Re-open stack in drawer.
10. Stack is correctly displayed.
(Reporter)

Comment 1

6 years ago
sfoster: this issue is partially present in the default branch as well, but I assigned it to you because it appears worse in the drawer-state branch.
(Assignee)

Comment 2

6 years ago
In the top-stacks branch, I got the place_title attribute being synced in the stackmodel when the active_page changes. Then, in the view we catch model attribute changes and attempt to just render that field via the attachPoints attribute name => selector mapping: 

See commits: https://bitbucket.org/mozillapancake/pancake/changeset/73da8142b2d0, 
https://bitbucket.org/mozillapancake/pancake/changeset/ded7d2c0fd78

lets review before I mark this done.
(Reporter)

Comment 3

6 years ago
I am still having state-related issues, but different ones. Here is a play-by-play of my testing. ! denotes a bug. * denotes "works as expected":

Wiped data: starting over.

* Search for "Sufjan Stevens"
* Clicked link, stack added
* Drawer navigated to.
* Correct place shown as active.
* Clicked link in page -> Place added below page
* Clicked back
! Clicked link in page -> place added below page. Getting inserted below correct place. Place appears smaller than others. Getting inserted in to the `<li>` of the parent page. That is not right. It should get inserted beneath.
! Clicked off of new page. Douple selection (probably because of where it is being inserted)
* Clicking between items issues warp.

Repeated above with "The Verge":
! Clicked off of new page. No double-selection.
! Clicking below wrongly-inserted stack results in double-selection.

Clicking out of stack and into "Sufjan" stack
* "Sufjan" Page is highlighted
* Click "BQE" page
! Uh-oh "All Delighted People" page has disappeared and has been replaced by a duplicate "BQE" page
! Click out of Sufjan stack. Stack title is not updated -- still says "Sufjan".
! Click back in to stack - double-selection of "BQE" page, but Sufjan Page is still displayed.

* Click in to "Verge" stack. Rendering has been fixed.
! Click out of "Verge" stack. "Sufjan" stack still displayed as active.

Refresh.

* Click "Sufjan" stack.
* "All Delighted People" page is back. The "BQE" page is highlighted and loaded.
* Click "All Delighted People" page.
* Click out of stack.
* Page title is reflected in stack.
* Click "The Verge" stack. It says that "The Changing Face of Ecommerce" is active.
* Stack displayed. "The Changing Face of Ecommerce" is highlighted as active.
* Click page "Garage Band for iPad"
* Click out of stack
* Updated page title is displayed in stack.
! Page titles appear to be doubled in stack list view for all stacks.
! "Sufjan" stack is still shown as active

Refresh.

* Click on "The Verge" stack.
! The "Changing Face of Ecommerce" is loaded and shown as active. Should be "Garage Band for iPad".
* Click OUT of stack into stack list.
* Click link "Jamie Keen"
* Stack title is updated in stack list
! Click into stack places view. "Changing Face of Ecommerce" is loaded and shown as active. Should be "Jamie Keen".
! Jamie Keen is added to the bottom of list. Should be directly below "Changing Face of Ecommerce".
Seeing this issue as well.  in some cases I can't get to the timeline after surfing while in the stack view for the side panel.
(Reporter)

Comment 5

6 years ago
Fixed. I'm not sure when the fix landed for this bug, but it's definitely no longer present in https://bitbucket.org/mozillapancake/pancake/changeset/7437c3e00cf6.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.