730148 - Handle OOM better in ValidateIncrementalMarking

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

There's some suggestion in bug 727334 that ValidateIncrementalMarking may be crashing due to OOM. This patch reorders things so that we deal better with OOM.

Comment 1

[Igor Bukanov]

Comment on attachment 600217 [details] [diff] [review]
patch

Review of attachment 600217 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +3058,5 @@
>  #ifdef DEBUG
>  static void
>  ValidateIncrementalMarking(JSContext *cx)
>  {
> +    typedef HashMap<Chunk *, uintptr_t *> BitmapMap;

Pre-existing issue: this should not report OOM as the error is not propagated. So replace the typedef with HashMap<Chunk *, uintptr_t *, GCChunkHasher, SystemAllocationPolicy> BitmapMap.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00ab2b295e84

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/00ab2b295e84