bzexport crashes on patches with no description

RESOLVED FIXED

Status

Developer Services
Mercurial: bzexport
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
It's a bad sign when nearly every time I run bzexport, I run into another problem. I should figure out how to set up a test suite. (I have one for part of the functionality, but it's too ugly to land.)
(Assignee)

Comment 1

6 years ago
Created attachment 600312 [details] [diff] [review]
imported patch empty-desc
Attachment #600312 - Flags: review?(josh)

Comment 2

6 years ago
Comment on attachment 600312 [details] [diff] [review]
imported patch empty-desc

Review of attachment 600312 [details] [diff] [review]:
-----------------------------------------------------------------

::: bzexport.py
@@ +952,5 @@
>      if update_patch:
>          # Add "Bug nnnn - " to the beginning of the description
>          ph = mq.patchheader(q.join(rev), q.plainmode)
>          msg = ph.message
> +        if len(msg) == 0:

Make this |if not msg|.
Attachment #600312 - Flags: review?(josh) → review+
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Other Applications → Developer Services
You need to log in before you can comment on or make changes to this bug.