Closed Bug 730206 Opened 8 years ago Closed 8 years ago

Avoid flash of white at startup

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
ProductDemo

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Avoid flash of white at startup (obsolete) — Splinter Review
No description provided.
Attachment #600316 - Flags: review?(jones.chris.g)
Comment on attachment 600316 [details] [diff] [review]
Avoid flash of white at startup

Review of attachment 600316 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/shell.xul
@@ +25,4 @@
>      <command id="cmd_close" oncommand="CommandUpdater.doCommand(this.id);"/>
>    </commandset>
>  
> +  <browser id="homescreen" type="content-primary" flex="1" style="overflow: hidden;" src="chrome://browser/content/black.html"/>

Instead of referring to black.html that has almost no content you could inline everything here in a data: url and save yourself the packaging step.
Attachment #600316 - Flags: review?(jones.chris.g) → review+
(In reply to Fabrice Desré [:fabrice] from comment #1)
> Comment on attachment 600316 [details] [diff] [review]
> Avoid flash of white at startup
> 
> Review of attachment 600316 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: b2g/chrome/content/shell.xul
> @@ +25,4 @@
> >      <command id="cmd_close" oncommand="CommandUpdater.doCommand(this.id);"/>
> >    </commandset>
> >  
> > +  <browser id="homescreen" type="content-primary" flex="1" style="overflow: hidden;" src="chrome://browser/content/black.html"/>
> 
> Instead of referring to black.html that has almost no content you could
> inline everything here in a data: url and save yourself the packaging step.

At the same time, data uris obscure the contents of the file. I'm not sure if there's much of an argument either way, though maybe inline might be faster.
Well, why not. It's probably faster.
Attachment #600316 - Attachment is obsolete: true
Attachment #600347 - Flags: review?(jones.chris.g)
Comment on attachment 600347 [details] [diff] [review]
Avoid flash of white at startup, v2

IRL r+
Attachment #600347 - Flags: review?(jones.chris.g) → review+
https://hg.mozilla.org/mozilla-central/rev/caba10b48567
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → ProductDemo
> At the same time, data uris obscure the contents of the file.

They don't need to.

data:text/html,<!DOCTYPE html><html><body style="background:black;"></body></html>
Depends on: 730296
You need to log in before you can comment on or make changes to this bug.