Avoid flash of white at startup

RESOLVED FIXED in ProductDemo

Status

Firefox OS
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

unspecified
ProductDemo

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 600316 [details] [diff] [review]
Avoid flash of white at startup
Attachment #600316 - Flags: review?(jones.chris.g)
Comment on attachment 600316 [details] [diff] [review]
Avoid flash of white at startup

Review of attachment 600316 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/shell.xul
@@ +25,4 @@
>      <command id="cmd_close" oncommand="CommandUpdater.doCommand(this.id);"/>
>    </commandset>
>  
> +  <browser id="homescreen" type="content-primary" flex="1" style="overflow: hidden;" src="chrome://browser/content/black.html"/>

Instead of referring to black.html that has almost no content you could inline everything here in a data: url and save yourself the packaging step.
Attachment #600316 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

6 years ago
(In reply to Fabrice Desré [:fabrice] from comment #1)
> Comment on attachment 600316 [details] [diff] [review]
> Avoid flash of white at startup
> 
> Review of attachment 600316 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: b2g/chrome/content/shell.xul
> @@ +25,4 @@
> >      <command id="cmd_close" oncommand="CommandUpdater.doCommand(this.id);"/>
> >    </commandset>
> >  
> > +  <browser id="homescreen" type="content-primary" flex="1" style="overflow: hidden;" src="chrome://browser/content/black.html"/>
> 
> Instead of referring to black.html that has almost no content you could
> inline everything here in a data: url and save yourself the packaging step.

At the same time, data uris obscure the contents of the file. I'm not sure if there's much of an argument either way, though maybe inline might be faster.
(Assignee)

Comment 3

6 years ago
Created attachment 600347 [details] [diff] [review]
Avoid flash of white at startup, v2

Well, why not. It's probably faster.
Attachment #600316 - Attachment is obsolete: true
Attachment #600347 - Flags: review?(jones.chris.g)
(Assignee)

Comment 4

6 years ago
Comment on attachment 600347 [details] [diff] [review]
Avoid flash of white at startup, v2

IRL r+
Attachment #600347 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/caba10b48567
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → ProductDemo
> At the same time, data uris obscure the contents of the file.

They don't need to.

data:text/html,<!DOCTYPE html><html><body style="background:black;"></body></html>

Updated

6 years ago
Depends on: 730296
You need to log in before you can comment on or make changes to this bug.