Closed Bug 730270 Opened 12 years ago Closed 12 years ago

js_malloc fails once every 2^32 allocations in DEBUG builds

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

v1
763 bytes, patch
luke
: review+
Details | Diff | Splinter Review 
See the definition of js_malloc and JS_OOM_POSSIBLY_FAIL in js/public/Utility.h.
Attached patch v1 — — Splinter Review 
Probably nobody ever runs a DEBUG build for the hours of continuous grind it would take to hit 2^32 allocations, but this bug is too gross to live.
Assignee: general → jorendorff
Attachment #600372 - Flags: review?(luke)
Comment on attachment 600372 [details] [diff] [review]
v1

lol
Attachment #600372 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/b1fd65f6165d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.