bugzilla.mozilla.org will be intermittently unavailable on Saturday, March 24th, from 16:00 until 20:00 UTC.

message sending broken if format dialog comes up.



MailNews Core
17 years ago
10 years ago


(Reporter: Bienvenu, Assigned: Blake Ross)



Windows NT

Firefox Tracking Flags

(Not tracked)



(2 attachments)



17 years ago
because of the xul landing, if you try to send html mail to someone and the msg
send format dialog pops up, you can't send mail. I have a potential fix for
this. However, it's just the tip of the iceberg - mail search is broken, and I
think most of the prefs ui is broken too.

Comment 1

17 years ago
seen this XP:

windows 2001-03-22-06-mtrunk
linux 2001-03-22-08-mtrunk
mac 2001-03-22-04-trunk
Keywords: smoketest
OS: Windows NT → All
Hardware: PC → All

Comment 2

17 years ago
ooops...my bad...linux doesn't even get this far...writing crasher bug for that

Comment 3

17 years ago
All of the mail prefs worked for me in testing, as did search. In class now, 
will look when I get home.
Keywords: smoketest
OS: All → Windows NT
Hardware: All → PC

Comment 4

17 years ago
It seems that some of the mailnews changes were lost or didn't get checked in 
somehow. I noticed this happened with MsgComposeCommands.js also.

Comment 5

17 years ago
Cc'ing people who can hopefully take a look until I get home (~2 hrs)

Comment 6

17 years ago
Created attachment 28478 [details] [diff] [review]
proposed fix

Comment 7

17 years ago
it looks to me like radio buttons still use the value setting. I'm also not sure
about the first changes (the setAttribute ones). I think it's the
getElementById.value change that matters.

I tried changing everything over to using data, i.e., the radio group part of
askFormat.xul, but that didn't work. I noticed all the other radio group things
in prefs were still using "value".

Comment 8

17 years ago
Radio buttons now use label to display the text (instead of value) and value to 
hold the internal value (instead of data). This fix is on the right track, but 
the other instances of data in askSendFormat.js need to be changed.

Comment 9

17 years ago
I have to leave for work, so I won't be able to get back to this for an hour or so.

Comment 10

17 years ago
change qa contact to myself, cc esther
QA Contact: esther → sheelar

Comment 11

17 years ago
The probable fix for this is known.  Can someone make the last few corrections 
in this file and check this in?  I won't be able to for another hour and a half.

Comment 12

17 years ago
blake, how many more missing checkins do you think there are?  If you still have
the fixes in your tree and there are many missing files, it might be a good idea
to wait for your tested version rather than spot fixing things.

Comment 13

17 years ago
The fixes can't be in my tree, I committed from the top.  Some of this may be 
fallout from the merge conflicts (in the rush to checkin, I may have forgotten 
to update some cases). In any case, can you please finish the work here and 
check it in?

Comment 14

17 years ago
adding the right keyword so this shows up on today's list.
Keywords: smoketest

Comment 15

17 years ago
I'm not going to be able to get to this for a while - I need to update my tree
and rebuild, which will take hours, and then I have meetings the rest of the
day. So if anyone else has an up to date tree, I'd appreciate it if they could
finish my fix.

thanks to blake and bienvenu for the patch.

I'll attach it so it can be reviewed after-the-fact by the parties that are
Last Resolved: 17 years ago
Resolution: --- → FIXED
Created attachment 28500 [details] [diff] [review]
the fix that got checked in.  blake, please do a post mortem.

Comment 18

17 years ago
*** Bug 73041 has been marked as a duplicate of this bug. ***

Comment 19

17 years ago
verified on the following builds
windows-2001-03-23-06(with work around)

cannont verify this on mac because of other blocker bugs(73041, 73445)

Comment 20

17 years ago
marking this bug as verified on mac (buildid: 2001-03-23-10) 
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.