730284 - undefined name 'FakeDatabaseConnection' in ConnectionContextPooled class

Status: RESOLVED WONTFIX

(Socorro Graveyard :: Middleware, defect)

Description

[[DEACTIVATED] Adrian Gaudebert]

Running check.py on our external folder raises the following error:

> external/postgresql/connection_context.py:166: undefined name 'FakeDatabaseConnection'

Comment 1

[Peter Bengtsson [:peterbe]]

A check.py, an error? Wow! That's really nitpicking it, isn't it? :)

The pooled class is not working at all to begin with. We don't use a pooled connection context because have the luxury of a pgbouncer. 
I tried to convince Lars to delete the code that is neither working, maintained or used but he says it ought to stay for "political" reasons. One of our goals is to be welcoming to other non-mozilla teams that want to use Socorro who might think that pgbouncer is overkill and prefer to do it in Python instead. This code would thus point to a good start on that. Sort of. 

We deliberately ignored all check.py messages for code that isn't used or test covered.