730437 - Some mis-organized or dead code in BWC and BrowserWrapper

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

In the course of trying to fix bug 608174, I discovered

1) BrowserWrapper contains two method declarations
- (void)addFindBarViewAndDisplay;
- (void)removeFindBarViewAndDisplay;
whose methods were removed when murph factored out the transient bar code (bug 418626)

2) BWC's find-related methods sit in the middle of (some of) the throbber-related methods; - (void)stopThrobber should move up above the find methods (and the two-lines-between-methods in between those methods can also be zapped).

There's probably a lot more nonsense in BWC due to design-by-accretion, but I'd like to get this part cleaned up.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Cleans up the specified items in BWC and BrowserWrapper

As described in comment 0.

[5:12pm] cl: sauron: a=me on the cleanup bug you just fied

Comment 2

[Stuart Morgan]

Comment on attachment 600522 [details] [diff] [review]
Cleans up the specified items in BWC and BrowserWrapper

sr=smorgan

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/5c93bfdbddd4

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

These are going to be in 2.1.3 instead.