Closed
Bug 730437
Opened 14 years ago
Closed 14 years ago
Some mis-organized or dead code in BWC and BrowserWrapper
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: alqahira)
References
Details
(Whiteboard: [camino-2.1.3])
Attachments
(1 file)
|
2.96 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
In the course of trying to fix bug 608174, I discovered
1) BrowserWrapper contains two method declarations
- (void)addFindBarViewAndDisplay;
- (void)removeFindBarViewAndDisplay;
whose methods were removed when murph factored out the transient bar code (bug 418626)
2) BWC's find-related methods sit in the middle of (some of) the throbber-related methods; - (void)stopThrobber should move up above the find methods (and the two-lines-between-methods in between those methods can also be zapped).
There's probably a lot more nonsense in BWC due to design-by-accretion, but I'd like to get this part cleaned up.
|
Assignee | |
Comment 1•14 years ago
|
||
As described in comment 0.
[5:12pm] cl: sauron: a=me on the cleanup bug you just fied
Attachment #600522 -
Flags: superreview?(stuart.morgan+bugzilla)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 600522 [details] [diff] [review]
Cleans up the specified items in BWC and BrowserWrapper
sr=smorgan
Attachment #600522 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.1.2]
|
|
Assignee | |
Comment 4•14 years ago
|
||
These are going to be in 2.1.3 instead.
Whiteboard: [camino-2.1.2] → [camino-2.1.3]
You need to log in
before you can comment on or make changes to this bug.
Description
•