Last Comment Bug 730501 - Import/Export feed buttons never enabled after bug 716706
: Import/Export feed buttons never enabled after bug 716706
: regression
Product: MailNews Core
Classification: Components
Component: Feed Reader (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 13.0
Assigned To: alta88
Depends on: 716706
  Show dependency treegraph
Reported: 2012-02-24 17:00 PST by :aceman
Modified: 2012-02-27 11:05 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

fix. (699 bytes, patch)
2012-02-25 13:54 PST, alta88
mozilla: review+
Details | Diff | Splinter Review

Description User image :aceman 2012-02-24 17:00:24 PST
The buttons are inoperational and disabled. It seems you wanted to allow them only on the .isServer item in the list (the account name), but that one does return item=undefined. Please check it.

Also the status line could be shown more prominently, or even highlighted when its content (a message) changes. It took me a while to notice where did my alert dialogs go. I thought they are not working.
Comment 1 User image alta88 2012-02-25 06:57:01 PST
please don't mix multiple unrelated issues in the same bug.

1. the import/export buttons are intentionally meant to be enabled only upon selection of a root account folder, to make clear to the user the imported tree is a child of that folder (and not a selected subfolder) and that the entire account opml is exported (and not a subfolder subset).

2. i'm not clear on the issue. an action (via button) shows the info message directly above the button so i don't know how it can be missed. anyway, unrelated.

closing; if there is an actual error, please reopen with detailed steps to reproduce.
Comment 2 User image :aceman 2012-02-25 10:51:54 PST
I have clicked everywhere in the tree of folders and the buttons were never enabled. Please attach a screenshot where I should click to enable Import and Export buttons.
Comment 3 User image alta88 2012-02-25 12:05:29 PST
aha.  the problem is a bad check; if you select the very first tree item, it will be the 0 index and incorrectly fail..  if you add a second feed account and select it, the check will pass.

a fix will be forthcoming.  thanks for the catch.
Comment 4 User image alta88 2012-02-25 13:54:39 PST
Created attachment 600718 [details] [diff] [review]
Comment 5 User image :aceman 2012-02-25 14:42:26 PST
Thanks, the fix works for me.
Comment 6 User image Ryan VanderMeulen [:RyanVM] 2012-02-26 12:34:01 PST

To make life easier for those checking in patches for you, please follow the directions below to make future patches easier to work with. Thanks!

Note You need to log in before you can comment on or make changes to this bug.