Syntax cleanup for the Account Wizard.

VERIFIED FIXED

Status

SeaMonkey
MailNews: Account Configuration
--
minor
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: stephend@netscape.com (gone - use stephen.donner@gmail.com instead), Assigned: stephend@netscape.com (gone - use stephen.donner@gmail.com instead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

Build ID: ALL, today's.

Just general cleanup involving parenthetical statements and where periods should
lie.  Patch next.
QA Contact: esther → nbaca
Created attachment 28493 [details] [diff] [review]
The patch.
Created attachment 28496 [details]
New, with changes (this is representative of the changes in other areas)
Created attachment 28497 [details]
What we used to look like.
Note: with this new patch, because the parenthetical statement is now part of a
regular sentence, the spacing becomes a little bit off in the default size of
the window (see screenshots).  If you resize the window, it's not a problem.  
Robin, this is perhaps hard to see in a patch only.  If you would like to come
review it on my build here, I'd be happy to show it to you.  Thanks.
Keywords: patch, review

Comment 6

17 years ago
r=robinf (reviewed the fixes in Stephen's debug build on his machine).
Seth, can you sr= this please? Thanks.
Keywords: review → approval
stephend: while you're at it, can you change the sample URIs in the text to
point to one of either "example.org", "example.net", "example.com", or, if
applicable, "domain.invalid"?

In particular, emailExample.label and the comment before it should be changed 
so that the e-mail address is "user@example.net", incomingServerNameDesc.label 
and its comment should be changed so that the POP server is "pop.example.net",
newsServerNameDesc.label and the comment before it should be changed to read
"news.example.net", and smtpServerDesc.label and its comment should have the
server name changed to "smtp.example.net".

See RFC2606 and bug 71121 for details.
Created attachment 28563 [details] [diff] [review]
Hixie, please review this patch.
You missed a comment ("<!-- LOCALIZATION NOTE (incomingServerNameDesc.label)"), 
otherwise looks ok. I don't know anything about XUL DTDs or .properties files
though, so I'm not really qualified to give an r=. Thanks!
Created attachment 28564 [details] [diff] [review]
Patch, changes the localization note.
sr=shaver.
Fix checked in.  Thanks to Robin, Ian, and Mike for speedy reviews.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 14

17 years ago
Build 2001-04-03-04: NT4
Build 2001-04-03-05: Linux RH 6.2
Build 2001-04-02-08: Mac 9.04
Verified Fixed.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.