Closed Bug 730526 Opened 11 years ago Closed 11 years ago

Cleanup and idiom in BrowserProvider.java.in

Categories

(Firefox for Android Graveyard :: General, defect, P5)

ARM
Android
defect

Tracking

(firefox13 verified)

VERIFIED FIXED
Firefox 13
Tracking Status
firefox13 --- verified

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file, 1 obsolete file)

Spotted a niggle with how the projection maps are initialized, and figured I'd do some cleanup.
Attached patch Proposed patch. v1 (obsolete) — Splinter Review
* MPL 2.0
* Use least-specific interface for provider column members (which allows for implementation switchout, and discourages perception of mutability)
* Use "create-modify-set" idiom for static initialization, rather than "create-set-modify"
* Use `unmodifiableMap` (alongside `final`) to ensure immutability.
Attachment #600597 - Flags: review?(lucasr.at.mozilla)
Depends on: 726382
Attached patch Rebased. v2Splinter Review
Had to adjust this on top of the GeckoProfile change.
Attachment #600597 - Attachment is obsolete: true
Attachment #600826 - Flags: review?(lucasr.at.mozilla)
Attachment #600597 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 600826 [details] [diff] [review]
Rebased. v2

Review of attachment 600826 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #600826 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/0f4106533b30
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Verified fixed on:

Firefox 13.0a1 (2012-03-05)
20120305031045
http://hg.mozilla.org/mozilla-central/rev/433cfbd2a0da

--
Device: HTC Desire
OS: Android 2.2
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.