Closed Bug 730527 Opened 11 years ago Closed 11 years ago

Fix compiler warnings in mozglue/android/APKOpen.cpp

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 13

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(1 file)

bug-730527-fix-apkopen-warnings.patch
3.08 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
This patch fixes the following compiler warnings when compiling Fennec on OSX:

    mozilla-central/mozglue/android/APKOpen.cpp: In function 'void extractLib(Zip::Stream&, void*)':
    mozilla-central/mozglue/android/APKOpen.cpp:417: warning: format '%d' expects type 'int', but argument 4 has type 'uLong'
    mozilla-central/mozglue/android/APKOpen.cpp: In function 'void loadGeckoLibs(const char*)':
    mozilla-central/mozglue/android/APKOpen.cpp:733: warning: format '%d' expects type 'int', but argument 4 has type 'long int'
    mozilla-central/mozglue/android/APKOpen.cpp:733: warning: format '%d' expects type 'int', but argument 5 has type 'long int'
    mozilla-central/mozglue/android/APKOpen.cpp:733: warning: format '%d' expects type 'int', but argument 6 has type 'long int'
    mozilla-central/mozglue/android/APKOpen.cpp:733: warning: format '%d' expects type 'int', but argument 7 has type 'long int'
    mozilla-central/mozglue/android/APKOpen.cpp: At global scope:
    mozilla-central/mozglue/android/APKOpen.cpp:391: warning: 'void extractLib(Zip::Stream&, void*)' defined but not used
    mozilla-central/mozglue/android/APKOpen.cpp:420: warning: 'cache_count' defined but not used


I have tested this patch on the try builders:
https://tbpl.mozilla.org/?tree=Try&rev=58bc26539975
Assignee: nobody → cpeterson

        Attachment #600599 -
        Flags: review?(mh+mozilla)

    
    

    
  
Comment on attachment 600599 [details] [diff] [review]
bug-730527-fix-apkopen-warnings.patch

There are so many other warnings that I'm not sure this is really worth doing. Especially considering that in the not so long term, most of this code will go away.

        Attachment #600599 -
        Flags: review?(mh+mozilla) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c916138691f5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.