If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Stop passing test names to compare-talos

RESOLVED FIXED

Status

Tree Management Graveyard
TBPL
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We load a compare-talos URL like http://perf.snarkfest.net/compare-talos/index.html?oldRevs=c1c6cd6c52b7&newRev=a65890126750&tests=a11y,tdhtml,tdhtml_nochrome,a11y_paint,tdhtml_paint,tdhtml_nochrome_paint,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,tp5,tp5_memset,tp5_pbytes,tp5_rss,tp5_shutdown,tp5_xres,tp5_paint,tp5_memset_paint,tp5_pbytes_paint,tp5_rss_paint,tp5_shutdown_paint,tp5_xres_paint,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tsspider_paint,tsspider_nochrome_paint,tgfx,tgfx_nochrome,tgfx_paint,tgfx_nochrome_paint,tscroll,tsvg,tsvg_opacity,ts,ts_paint,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen,tpaint&submit=true to get every test selected.

Because the talos test names are changing every week, or twice a week, and we almost never update our list of names, that doesn't actually get every test.

http://perf.snarkfest.net/compare-talos/index.html?oldRevs=c1c6cd6c52b7&newRev=a65890126750&submit=true does get every test (every test that compare-talos knows about, at least, which is what matters).

Oops.
(Assignee)

Comment 1

6 years ago
Created attachment 600620 [details] [diff] [review]
rm

+2, -64, that's my kind of diffstat :)
Attachment #600620 - Flags: review?(arpad.borsos)
Comment on attachment 600620 [details] [diff] [review]
rm

Review of attachment 600620 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch :-)
Attachment #600620 - Flags: review?(arpad.borsos) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/86204a11d671
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.