730710 - GeckoEventListener implementations cannot return a value

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Add GeckoEventResponder to allow responding to events

Right now there is no good way for implementations of GeckoEventListener to return a value back to the code that sent the event in browser.js, even though the event architecture supports this functionality. The only way to do it is by sticking the event handling code directly in GeckoAppShell.handleGeckoMessage which is pretty ugly.

There are many possible ways to add support for this; I picked one which reduces the impact on existing GeckoEventListener implementations.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 600795 [details] [diff] [review]
Add GeckoEventResponder to allow responding to events

Review of attachment 600795 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAppShell.java
@@ +1751,5 @@
> +                listener.handleMessage(type, geckoObject);
> +                if (listener instanceof GeckoEventResponder) {
> +                    String newResponse = ((GeckoEventResponder)listener).getResponse();
> +                    if (response != null && newResponse != null) {
> +                        throw new Exception("Received two responses for message of type " + type);

just log here rather than throw. It gets caught a few lines below and there's no reason to not notify any other listeners that are registered.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Landed on inbound with the suggested change.

https://hg.mozilla.org/integration/mozilla-inbound/rev/75deec1f1a7b

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/75deec1f1a7b