730715 - kumascript: Minimize template loading and execution

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Les Orchard [:lorchard]]

This probably deserves its own bug. To get and compile templates used by macros, kumascript needs to make HTTP requests to Kuma for wiki doc source. The response from this request can be cached, but we need to be smart about it.

* Templates need to be reloaded and recompiled whenever the source is edited
* How long can cache entries live, assuming none of the above changes? (ie. 5 min? 60 min?)

Comment 1

[Les Orchard [:lorchard]]

Progress: https://github.com/mozilla/kumascript/pull/3

I've kind of rethought this bug a bit. It doesn't seem like using HTTP caching for templates from Kuma ends up being a very big win. I'm having a hard time thinking of a useful scenario where a fresh response from kumascript shouldn't also fetch a fresh document and fresh copies of all the templates needed.

So, instead, I spent some time reworking things so that:

* Templates only get loaded once for each uniquely named macro (ie. HTMLElement vs CSSXref)

* Templates only get executed once for each unique combination of macro name and arguments (ie. HTMLElement('li') vs HTMLElement('div'))

That should minimize both HTTP traffic and CPU time even when generating a fresh evaluation of a wiki document.

Comment 2

[Les Orchard [:lorchard]]

I think this has been merged