730717 - Add some reftests for media controls

Status: NEW

(Toolkit :: Video/Audio Controls, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug

We should add some initial reftests for the media controls (both audio and video). These tests can be used to also check to make sure that changes such as bug 462117 and bug 689374 work properly.

The patch attached to this bug was built on top of the patch for bug 723051.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug

Forgot to include some files.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Have you pushed this to try? Would anitaliasing differences between platforms cause this to fail on different platforms?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Chris Pearce (:cpearce) from comment #2)
> Have you pushed this to try? Would anitaliasing differences between
> platforms cause this to fail on different platforms?

I will push it to the tryserver once bug 723051 gets merged to mozilla-central.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Pushed to tryserver: https://tbpl.mozilla.org/?tree=Try&rev=1a1518cb1d62

If the tests fail on different platforms, we could still get a smaller win by making these tests run on only one platform.

Comment 5

[Mozilla RelEng Bot]

Try run for 1a1518cb1d62 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1a1518cb1d62
Results (out of 37 total builds):
    success: 35
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-1a1518cb1d62

Comment 6

[Wesley Johnston (:wesj)]

Hey, just wanted to cc myself and note that I'm sick of fixing my own bugs in the touch controls too. Plus I want to add some touchevent listeners to make them react quickly without breaking them along the way. If there's some way we can use this to test them as well, I'm happy to write code.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Wesley Johnston (:wesj) from comment #6)
> I want to add some touchevent listeners to
> make them react quickly without breaking them along the way. If there's some
> way we can use this to test them as well, I'm happy to write code.

Reftests could be a way to test these. You can use the class 'reftest-wait' on the body class to delay the comparison until you are ready. See http://mxr.mozilla.org/mozilla-central/source/image/test/reftest/apng/delaytest.html?force=1 for an example.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: example of one of the reftest images

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: another example of one of the reftest images

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: an example of one of the reftest images for audio

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug v2

Added a reference to the tests in /layout/reftests/reftest.list.

Comment 12

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 604602
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=e082380e46e3
Try run started, revision e082380e46e3. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=e082380e46e3

Comment 13

[Mozilla RelEng Bot]

Try run for e082380e46e3 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=e082380e46e3
Results (out of 37 total builds):
    success: 18
    warnings: 19
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-e082380e46e3