Open Bug 730717 Opened 10 years ago Updated 9 years ago

Add some reftests for media controls

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set
normal

Tracking

()

People

(Reporter: jaws, Unassigned)

Details

Attachments

(4 files, 2 obsolete files)

Attached patch Patch for bug (obsolete) — Splinter Review
We should add some initial reftests for the media controls (both audio and video). These tests can be used to also check to make sure that changes such as bug 462117 and bug 689374 work properly.

The patch attached to this bug was built on top of the patch for bug 723051.
Attachment #600805 - Flags: review?(dolske)
Attached patch Patch for bug (obsolete) — Splinter Review
Forgot to include some files.
Attachment #600805 - Attachment is obsolete: true
Attachment #600806 - Flags: review?(dolske)
Attachment #600805 - Flags: review?(dolske)
Have you pushed this to try? Would anitaliasing differences between platforms cause this to fail on different platforms?
(In reply to Chris Pearce (:cpearce) from comment #2)
> Have you pushed this to try? Would anitaliasing differences between
> platforms cause this to fail on different platforms?

I will push it to the tryserver once bug 723051 gets merged to mozilla-central.
Pushed to tryserver: https://tbpl.mozilla.org/?tree=Try&rev=1a1518cb1d62

If the tests fail on different platforms, we could still get a smaller win by making these tests run on only one platform.
Try run for 1a1518cb1d62 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1a1518cb1d62
Results (out of 37 total builds):
    success: 35
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jwein@mozilla.com-1a1518cb1d62
Hey, just wanted to cc myself and note that I'm sick of fixing my own bugs in the touch controls too. Plus I want to add some touchevent listeners to make them react quickly without breaking them along the way. If there's some way we can use this to test them as well, I'm happy to write code.
(In reply to Wesley Johnston (:wesj) from comment #6)
> I want to add some touchevent listeners to
> make them react quickly without breaking them along the way. If there's some
> way we can use this to test them as well, I'm happy to write code.

Reftests could be a way to test these. You can use the class 'reftest-wait' on the body class to delay the comparison until you are ready. See http://mxr.mozilla.org/mozilla-central/source/image/test/reftest/apng/delaytest.html?force=1 for an example.
Attached patch Patch for bug v2Splinter Review
Added a reference to the tests in /layout/reftests/reftest.list.
Attachment #600806 - Attachment is obsolete: true
Attachment #600806 - Flags: review?(dolske)
Whiteboard: [autoland-try:-b do -p all -u reftest,reftest-ipc,reftest-no-accel -t none]
Whiteboard: [autoland-try:-b do -p all -u reftest,reftest-ipc,reftest-no-accel -t none] → [autoland-in-queue]
Autoland Patchset:
	Patches: 604602
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=e082380e46e3
Try run started, revision e082380e46e3. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=e082380e46e3
Try run for e082380e46e3 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=e082380e46e3
Results (out of 37 total builds):
    success: 18
    warnings: 19
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-e082380e46e3
Whiteboard: [autoland-in-queue]
Assignee: jAwS → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.