The default bug view has changed. See this FAQ.

Support animation when opening document-like windows in Lion (OS X 10.7).

RESOLVED FIXED in seamonkey2.13

Status

SeaMonkey
UI Design
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: lavina)

Tracking

Trunk
seamonkey2.13
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=stefanh][lang=xul])

Attachments

(1 attachment, 2 obsolete attachments)

7.84 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
Bug 674370:

> When opening the application on OS X Lion, we should use the same animation
> as the other applications. (Zoom in)

Bug 728493:

> This patch will add the window animation in Lion to the standalone window,
> the main window, the addressbook and the compose window.
(Reporter)

Comment 1

5 years ago
References:
  FX Bug 674370 - [10.7] Support animation when opening windows in Lion.
  TB Bug 728493 - Add Lion window opening animation (zoom on creation) to Thunderbird.
(Assignee)

Comment 2

5 years ago
I'll take this.
(Reporter)

Comment 3

5 years ago
Thank you. Please visit irc://moznet/seamonkey if you need to discuss anything or need help with your patch.
(Assignee)

Comment 4

5 years ago
Created attachment 629447 [details] [diff] [review]
patch for Bug 730751

mainly added macanimationtype="document" to navigator.xul, addressbook.xul,messagecompose.xul, messenger.xul, messageWindow.xul.
(Assignee)

Updated

5 years ago
Attachment #629447 - Flags: review?(stefanh)

Comment 5

5 years ago
Thanks for the patch lavina, I'll try to look at it asap (in 1-2 days).
Assignee: nobody → orangedaylily
Status: NEW → ASSIGNED
Target Milestone: --- → seamonkey2.12

Comment 6

5 years ago
Comment on attachment 629447 [details] [diff] [review]
patch for Bug 730751

This looks good - thanks!

But we should animate the Composer window too. So, r=me if you put up a new patch with 'macanimationtype="document"' added to editor.xul (in editor/ui/composer/content).
Attachment #629447 - Flags: review?(stefanh) → review+

Comment 7

5 years ago
Do any of our add-ons need this?

(In reply to Stefan from comment #6)
> (From update of attachment 629447 [details] [diff] [review])
> But we should animate the Composer window too.
Also the plain text editor in debugQA please.

Comment 8

5 years ago
(In reply to neil@parkwaycc.co.uk from comment #7)
> Do any of our add-ons need this?

We could do it for chatzilla, but maybe we could handle that in a separate bug.
> 
> (In reply to Stefan from comment #6)
> > (From update of attachment 629447 [details] [diff] [review])
> > But we should animate the Composer window too.
> Also the plain text editor in debugQA please.

Right, that would be comm-central/source/suite/debugQA/content/debugQATextEditorShell.xul.
(Assignee)

Comment 9

5 years ago
Created attachment 630433 [details] [diff] [review]
updated patch

added macanimationtype for editor.xul and debugQATextEditorShell.xul.
Attachment #629447 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #630433 - Flags: review?(stefanh)

Comment 10

5 years ago
Comment on attachment 630433 [details] [diff] [review]
updated patch

Thanks. I'm one of the few SM devs that use Mac, so my review makes sense here. But since I'm not an official peer and this patch also touches mailNews and editor, I think we need additional review here.
Attachment #630433 - Flags: review?(stefanh)
Attachment #630433 - Flags: review?(neil)
Attachment #630433 - Flags: review+
Comment on attachment 630433 [details] [diff] [review]
updated patch

>         windowtype="msgcompose"
>         width="640" height="480"
>-        persist="screenX screenY width height sizemode">
>+        persist="screenX screenY width height sizemode"
>+        macanimationtype="document">
Sorry for not noticing this in the first patch, but I'd like all of the mail windows to match the non-mail windows where you add the macanimationtype after the windowtype to avoid changing the line ending in >. r=me with that fixed.
Attachment #630433 - Flags: review?(neil) → review+
(Assignee)

Comment 12

5 years ago
Created attachment 631614 [details] [diff] [review]
updated patch
Attachment #630433 - Attachment is obsolete: true
Attachment #631614 - Flags: review?(neil)

Updated

5 years ago
Attachment #631614 - Flags: review?(neil) → review+

Comment 13

5 years ago
Thanks a lot for the patch, lavina. I've pushed your patch to comm-central:
http://hg.mozilla.org/comm-central/rev/29e0c83f32e7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: seamonkey2.12 → seamonkey2.13
You need to log in before you can comment on or make changes to this bug.