Closed Bug 730814 Opened 12 years ago Closed 12 years ago

Update about:license to MPL 2

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 13

People

(Reporter: gerv, Assigned: gerv)

Details

Attachments

(1 file)

We should remove the MPL 1.1, LGPL and GPL license texts, and replace them with the MPL 2 text (plus perhaps a note about LGPL and GPL compatibility, modelled on the one written for NSS in bug 716563). 

We can do this before switching all the code headers (bug 716478) - there's no legal problem with that, as MPL 1.1 allows distribution under later versions.

Gerv
Luis: can you sanity-check comment 0 before I go ahead with this?

Thanks :-)

Gerv
That sounds correct to me. I would hope that the compatibility language is unnecessary or could perhaps be addressed in the FAQ?
Yep, OK, we can link to the FAQ.

Gerv
Attached patch Patch v.1Splinter Review
This switches to MPL 2, adding a link to the FAQ, corrects a few inaccuracies about what license applies to what, and also makes the document validate as HTML5.

Gerv
Assignee: nobody → gerv
Status: NEW → ASSIGNED
Attachment #601235 - Flags: review?(villalu)
Comment on attachment 601235 [details] [diff] [review]
Patch v.1

Review of attachment 601235 [details] [diff] [review]:
-----------------------------------------------------------------

The pedant in me says that all the name -> id changes should be in a different commit, but otherwise this looks fine to me.
Comment on attachment 601235 [details] [diff] [review]
Patch v.1

I am afraid that I am unable to figure out how to formally r+ this in the UI, but as plain-old-text, here is an r+.
Comment on attachment 601235 [details] [diff] [review]
Patch v.1

Click "Details", then change the "review" flag to "+".

Gerv
Attachment #601235 - Flags: review?(villalu) → review+
https://hg.mozilla.org/mozilla-central/rev/beb93f812874
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
The link to the MPL section doesn't work because about:license#mpl doesn't exist as a named anchor.
(In reply to Gervase Markham [:gerv] from comment #11)
> djcater: thanks; fixed.
> https://hg.mozilla.org/integration/mozilla-inbound/rev/fc874873ea21
> 
> Gerv

    1.48 +        <li><span class="path">msvc*.dll</span> (C and C++ runtime libraries)</li>

Why did that need to be added?

Shouldn't the Microsoft changes be reviewed and checked in separately (in a different bug)? You've changed the name of the licence, the layout of it, and the files it covers all under the commit comment of "Add "mpl" anchor.".
Oops. That is a patch for a different bug. I'll work on a backout.

Gerv
There we go:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a66cd5f0790e

That's better. Thanks!

Gerv
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: