Closed Bug 730825 Opened 8 years ago Closed 8 years ago

Slay nsDoubleHashtable.h

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(2 files, 1 obsolete file)

People should be using nsTHashtable instead.
Lots of nsDoubleHashtable usage in content/ (which, surprisingly, is the only place it was used).  This patch at least compiles; no word on whether it passes tests.
Whiteboard: [autoland-try:-b do -p all -u all -t none]
Whiteboard: [autoland-try:-b do -p all -u all -t none] → [autoland-in-queue]
Autoland Patchset:
	Patches: 601643
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=9ef8cc556cdb
Try run started, revision 9ef8cc556cdb. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=9ef8cc556cdb
Try run for 9ef8cc556cdb is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=9ef8cc556cdb
Results (out of 216 total builds):
    exception: 1
    success: 175
    warnings: 36
    failure: 4
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-9ef8cc556cdb
Whiteboard: [autoland-in-queue]
Comment on attachment 601643 [details] [diff] [review]
remove nsDoubleHashtable.h from content

Since this passes tests, hopefully it will pass review too.
Attachment #601643 - Flags: review?(jonas)
Nuke it from orbit, it's the only way to be sure.
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Attachment #602348 - Flags: review?(benjamin)
Comment on attachment 601643 [details] [diff] [review]
remove nsDoubleHashtable.h from content

Review of attachment 601643 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you fix the below comment. Thanks for doing this!

::: content/xslt/src/xslt/txKeyFunctionCall.cpp
@@ +151,5 @@
>  /**
>   * Hash functions
>   */
> +typedef nsTHashtable<txKeyValueHashEntry> txKeyValueHash;
> +typedef nsTHashtable<txIndexedKeyHashEntry> txIndexedKeyHash;

You shouldn't need to duplicate these typedefs. Doesn't this file include txKey.h?
Attachment #601643 - Flags: review?(jonas) → review+
(In reply to Jonas Sicking (:sicking) from comment #6)
> ::: content/xslt/src/xslt/txKeyFunctionCall.cpp
> > +typedef nsTHashtable<txKeyValueHashEntry> txKeyValueHash;
> > +typedef nsTHashtable<txIndexedKeyHashEntry> txIndexedKeyHash;
> 
> You shouldn't need to duplicate these typedefs. Doesn't this file include
> txKey.h?

Indeed, thanks for catching that.
Deleting typedefs, carrying over r+.
Attachment #601643 - Attachment is obsolete: true
Attachment #602363 - Flags: review+
Whiteboard: [autoland-try:-b do -p all -u all -t none]
Whiteboard: [autoland-try:-b do -p all -u all -t none] → [autoland-in-queue]
Autoland Patchset:
	Patches: 602348, 602363
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=3f60544d5da7
Try run started, revision 3f60544d5da7. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=3f60544d5da7
Try run for 3f60544d5da7 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=3f60544d5da7
Results (out of 217 total builds):
    exception: 2
    success: 171
    warnings: 44
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-3f60544d5da7
Whiteboard: [autoland-in-queue]
Attachment #602348 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.