730832 - Customization palette should calculate its width dynamically so it always shows four columns

Status: NEW

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: WIP patch for bug

Bug 714277 adjusted the default width of the Customize Toolbars dialog so that we would still show four columns after bug 419231 landed. The solution for that bug was a temporary stop-gap until we implement a dynamic solution that calculates the width.



Copied from bug 714277:
I have attached a WIP patch for this bug. I've added the inner box and the window *should* now resize by the difference of 4*itemWidth and the inner box when the inner box is not big enough to fit four columns. However, this does not have the effect that I hoped.

The inner box has a boxObject.width of 126 when the window is loaded. Each item is 130 pixels wide (110 width + 4px padding + 16px margins). When calling |window.resizeBy(394, 0)|, the window doesn't get wide enough to fit four columns (the inner box is 479px wide, 25 pixels too narrow), and the window height is stuck at 38 pixels tall.

Do you know why calling window.resizeBy with a deltaY of 0 would stop the window from opening at the preserved height and why extra width added to the window isn't enough?

This patch works around the issue that I was seeing with window.resizeBy by using setTimeout. It's an ugly hack that causes the window to appear out of position for a split second and then move to the correct position and dimensions.