Closed Bug 730967 Opened 10 years ago Closed 9 years ago

MAPLE: Don't recompute checkerboard color every frame

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(2 files)

Attached patch patchSplinter Review
Recomputing the checkerboard color every frame is expensive and is showing up in the time line. We should only do it once per page.
Attachment #601039 - Flags: review?(pwalton)
Comment on attachment 601039 [details] [diff] [review]
patch

Review of attachment 601039 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #601039 - Flags: review?(pwalton) → review+
From a look at https://hg.mozilla.org/projects/maple/rev/27b212422b56 it doesn't appear that the java side handles a null bgColor coming through properly; it will probably throw a NPE on the call to sColorPattern.matcher(string).

(Also, the indent on one of the lines in GeckoApp is wrong)
Attached patch follow up fixSplinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #601707 - Flags: review?(bugmail.mozilla)
Attachment #601707 - Flags: review?(bugmail.mozilla) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.