Closed
Bug 730967
Opened 13 years ago
Closed 13 years ago
MAPLE: Don't recompute checkerboard color every frame
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(2 files)
|
11.65 KB,
patch
|
pcwalton
:
review+
|
Details | Diff | Splinter Review |
|
1.43 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Recomputing the checkerboard color every frame is expensive and is showing up in the time line. We should only do it once per page.
Attachment #601039 -
Flags: review?(pwalton)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 601039 [details] [diff] [review]
patch
Review of attachment 601039 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Attachment #601039 -
Flags: review?(pwalton) → review+
|
||
Comment 2•13 years ago
|
||
From a look at https://hg.mozilla.org/projects/maple/rev/27b212422b56 it doesn't appear that the java side handles a null bgColor coming through properly; it will probably throw a NPE on the call to sColorPattern.matcher(string).
(Also, the indent on one of the lines in GeckoApp is wrong)
|
Assignee | |
Comment 3•13 years ago
|
||
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #601707 -
Flags: review?(bugmail.mozilla)
|
|
||
Updated•13 years ago
|
Attachment #601707 -
Flags: review?(bugmail.mozilla) → review+
|
||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Updated•13 years ago
|
Blocks: checkerboarding
You need to log in
before you can comment on or make changes to this bug.
Description
•