730996 - HTML5 audio controls disappear after starting playback

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Markus Popp]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0a2) Gecko/20120227 Firefox/12.0a2
Build ID: 20120227042012

Steps to reproduce:

This seems to affect both XUL version (10.0.2) and Native version (13.0a1 from February 27, 2012) of Firefox Mobile.

When an HTML5 audio implemented e.g. as

<audio src="..." controls="controls">

is started, the controls mysteriously disappear, although the audio itself is playing.

Tested this on a Samsung Galaxy S2 with Android 2.3.6. The same could also be repeated with Firefox Mobile (XUL) 10.0.2 on a Google Nexus S running Android 4.0.3.

A test case with a minimal implementation is available at http://var.mpopp.net/audio/


Actual results:

Controls disappear, audio is playing. There is no longer a UI element to stop audio playback.


Expected results:

Controls should not disappear.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

This fixes this and seems in line with what we do throughout the normal controls.

Comment 2

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3af0028393d

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/c3af0028393d

Comment 4

[Markus Popp]

Thanks for fixing this so quickly!

As this affects the XUL version too, will this bug fix also go into Firefox Mobile 11?

Comment 5

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-02-29)
20120229031108
http://hg.mozilla.org/mozilla-central/rev/30b4f99a137c

--
Device: Samsung Galaxy S2
OS: Android 2.3.4

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 601075 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): Old bug in our touch controls that no one ever ran into. Affects XUL and Native Fennec.
User impact if declined: Audio can be impossible to pause.
Testing completed (on m-c, etc.): Has been on mc since 2-17
Risk to taking this patch (and alternatives if risky): Very low risk. Mobile is the only consumer of these controls. The change is very small and localized.
String changes made by this patch: None.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 601075 [details] [diff] [review]
Patch

[Triage Comment]
Neither XUL nor Native Fennec will be shipping off of the FF11 branch, and considering this is in shared code, we'll only take for Aurora 12.