Closed
Bug 731019
Opened 13 years ago
Closed 13 years ago
java.lang.NullPointerException: at org.mozilla.gecko.AwesomeBarTabs.onBackPressed(AwesomeBarTabs.java)
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: scoobidiver, Assigned: Margaret)
References
Details
(Keywords: crash, regression, Whiteboard: [native-crash])
Crash Data
Attachments
(1 file)
1.49 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
It first appeared in 13.0a1/20120225.
java.lang.NullPointerException
at org.mozilla.gecko.AwesomeBarTabs.onBackPressed(AwesomeBarTabs.java:326)
at org.mozilla.gecko.AwesomeBar$3.onKeyPreIme(AwesomeBar.java:182)
at org.mozilla.gecko.AwesomeBar$AwesomeBarEditText.onKeyPreIme(AwesomeBar.java:568)
at android.view.View.dispatchKeyEventPreIme(View.java:3882)
at android.view.ViewGroup.dispatchKeyEventPreIme(ViewGroup.java:776)
at android.view.ViewGroup.dispatchKeyEventPreIme(ViewGroup.java:776)
at android.view.ViewGroup.dispatchKeyEventPreIme(ViewGroup.java:776)
at android.view.ViewGroup.dispatchKeyEventPreIme(ViewGroup.java:776)
at android.view.ViewRoot.deliverKeyEvent(ViewRoot.java:2572)
at android.view.ViewRoot.handleMessage(ViewRoot.java:1883)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:130)
at org.mozilla.gecko.GeckoApp$35.run(GeckoApp.java:1798)
at android.os.Handler.handleCallback(Handler.java:587)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:130)
at android.app.ActivityThread.main(ActivityThread.java:3691)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:507)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:907)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:665)
at dalvik.system.NativeStart.main(Native Method)
More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A%20at%20org.mozilla.gecko.AwesomeBarTabs.onBackPressed%28AwesomeBarTabs.java%29
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → margaret.leibovic
Reporter | ||
Updated•13 years ago
|
Keywords: regression
Assignee | ||
Comment 2•13 years ago
|
||
It looks like this could happen if the user switches to the bookmarks tab and then presses back quickly, before BookmarksQueryTask has finished. In this case, the user wouldn't have entered a folder, so returning false will do the correct thing and exit the awesome screen activity.
Attachment #601452 -
Flags: review?(lucasr.at.mozilla)
Comment 3•13 years ago
|
||
Comment on attachment 601452 [details] [diff] [review]
patch
Review of attachment 601452 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch.
::: mobile/android/base/AwesomeBarTabs.java
@@ +319,5 @@
> // This method checks to see if we're in a bookmark sub-folder. If we are,
> // it will go up a level and return true. Otherwise it will return false.
> public boolean onBackPressed() {
> + // If we're not in the bookmarks tab, we have nothing to do. We should
> + // also return false mBookmarksAdapter hasn't been initialized yet.
"if mBookmarksAdapter"
Attachment #601452 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Updated•12 years ago
|
tracking-fennec: ? → ---
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•