If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove devicemanager's communicate method

RESOLVED FIXED in mozilla13

Status

Testing
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Trunk
mozilla13
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It's a confusing method (assuming that output from a running process goes to a file called "temp.txt". Nothing uses it in mozilla-central (or talos).
(In reply to William Lachance (:wlach) from comment #0)
> It's a confusing method (assuming that output from a running process goes to
> a file called "temp.txt". Nothing uses it in mozilla-central (or talos).

... except for a test program which doesn't even work, which I will also remove as part of this patch.
Created attachment 601106 [details] [diff] [review]
Very straightforward patch to remove unused method
Assignee: nobody → wlachance
Attachment #601106 - Flags: review?(jmaher)
Comment on attachment 601106 [details] [diff] [review]
Very straightforward patch to remove unused method

Review of attachment 601106 [details] [diff] [review]:
-----------------------------------------------------------------

can you run this through try server?
Attachment #601106 - Flags: review?(jmaher) → review+

Comment 4

6 years ago
Try run for 32695b4648e5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=32695b4648e5
Results (out of 29 total builds):
    exception: 2
    success: 24
    warnings: 2
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/wlachance@mozilla.com-32695b4648e5
(In reply to Mozilla RelEng Bot from comment #4)
> Try run for 32695b4648e5 is complete.
> Detailed breakdown of the results available here:
>     https://tbpl.mozilla.org/?tree=Try&rev=32695b4648e5
> Results (out of 29 total builds):
>     exception: 2
>     success: 24
>     warnings: 2
>     failure: 1
> Builds (or logs if builds failed) available at:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/wlachance@mozilla.
> com-32695b4648e5

Everything looks good here, except for the usual intermittent failures.

Comment 6

6 years ago
m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/0983ca6b6ce6
https://hg.mozilla.org/mozilla-central/rev/0983ca6b6ce6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.