Last Comment Bug 731162 - Zap nsIParser::Parse(const nsAString&, ...
: Zap nsIParser::Parse(const nsAString&, ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Henri Sivonen (:hsivonen)
:
Mentors:
Depends on: 650776 798275
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-28 03:11 PST by Henri Sivonen (:hsivonen)
Modified: 2012-11-29 16:24 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Zap the method from nsIParser, inline constant arguments in nsParser (12.55 KB, patch)
2012-02-28 03:41 PST, Henri Sivonen (:hsivonen)
no flags Details | Diff | Review
Zap the method from nsIParser, inline constant arguments in nsParser (12.55 KB, patch)
2012-03-21 23:31 PDT, Henri Sivonen (:hsivonen)
bugs: review+
Details | Diff | Review

Description Henri Sivonen (:hsivonen) 2012-02-28 03:11:02 PST
Remove legacy code when it becomes dead code.
Comment 1 Henri Sivonen (:hsivonen) 2012-02-28 03:20:46 PST
Aargh. nsParser still has internal dependencies on this for XML fragment parsing. Scoping for zapping it from nsIParser only in order to avoid new callers cropping up.
Comment 2 Henri Sivonen (:hsivonen) 2012-02-28 03:41:23 PST
Created attachment 601232 [details] [diff] [review]
Zap the method from nsIParser, inline constant arguments in nsParser

Oh well. This turned out to be not much of a removal win at this point.
Comment 3 Henri Sivonen (:hsivonen) 2012-03-21 23:31:49 PDT
Created attachment 608240 [details] [diff] [review]
Zap the method from nsIParser, inline constant arguments in nsParser

Even though this removal turned out not to be much of a win, I want to remove this method from nsIParser to make sure comm-central or XULRunner apps don't add new calls to it while I'm not paying attention.
Comment 4 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-03-23 03:47:29 PDT
how much would it take remove the xml dependencies.
Comment 5 Henri Sivonen (:hsivonen) 2012-03-23 03:49:38 PDT
(In reply to Olli Pettay [:smaug] from comment #4)
> how much would it take remove the xml dependencies.

It looked complicated enough not to be worth it before the larger XML code path rewrite. (Check out what the XML code path does. It's quite horrible.)
Comment 6 Henri Sivonen (:hsivonen) 2012-03-26 23:56:07 PDT
Thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/902b81504db9
Comment 7 Ed Morley [:emorley] 2012-03-28 14:27:02 PDT
https://hg.mozilla.org/mozilla-central/rev/902b81504db9

Note You need to log in before you can comment on or make changes to this bug.