731162 - Zap nsIParser::Parse(const nsAString&, ...

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Henri Sivonen (:hsivonen)]

Remove legacy code when it becomes dead code.

Comment 1

[Henri Sivonen (:hsivonen)]

Aargh. nsParser still has internal dependencies on this for XML fragment parsing. Scoping for zapping it from nsIParser only in order to avoid new callers cropping up.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Zap the method from nsIParser, inline constant arguments in nsParser

Oh well. This turned out to be not much of a removal win at this point.

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Zap the method from nsIParser, inline constant arguments in nsParser

Even though this removal turned out not to be much of a win, I want to remove this method from nsIParser to make sure comm-central or XULRunner apps don't add new calls to it while I'm not paying attention.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

how much would it take remove the xml dependencies.

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to Olli Pettay [:smaug] from comment #4)
> how much would it take remove the xml dependencies.

It looked complicated enough not to be worth it before the larger XML code path rewrite. (Check out what the XML code path does. It's quite horrible.)

Comment 6

[Henri Sivonen (:hsivonen)]

Thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/902b81504db9

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/902b81504db9