Zap nsIParser::Parse(const nsAString&, ...

RESOLVED FIXED in mozilla14

Status

()

Core
HTML: Parser
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Remove legacy code when it becomes dead code.
(Assignee)

Updated

5 years ago
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Aargh. nsParser still has internal dependencies on this for XML fragment parsing. Scoping for zapping it from nsIParser only in order to avoid new callers cropping up.
Summary: Zap nsParser::Parse(const nsAString&, ... → Zap nsIParser::Parse(const nsAString&, ...
(Assignee)

Comment 2

5 years ago
Created attachment 601232 [details] [diff] [review]
Zap the method from nsIParser, inline constant arguments in nsParser

Oh well. This turned out to be not much of a removal win at this point.
(Assignee)

Comment 3

5 years ago
Created attachment 608240 [details] [diff] [review]
Zap the method from nsIParser, inline constant arguments in nsParser

Even though this removal turned out not to be much of a win, I want to remove this method from nsIParser to make sure comm-central or XULRunner apps don't add new calls to it while I'm not paying attention.
Attachment #601232 - Attachment is obsolete: true
Attachment #608240 - Flags: review?(bugs)

Comment 4

5 years ago
how much would it take remove the xml dependencies.
(Assignee)

Comment 5

5 years ago
(In reply to Olli Pettay [:smaug] from comment #4)
> how much would it take remove the xml dependencies.

It looked complicated enough not to be worth it before the larger XML code path rewrite. (Check out what the XML code path does. It's quite horrible.)

Updated

5 years ago
Attachment #608240 - Flags: review?(bugs) → review+
(Assignee)

Comment 6

5 years ago
Thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/902b81504db9

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/902b81504db9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Depends on: 798275
You need to log in before you can comment on or make changes to this bug.