731172 - "View Selection Source" generates extra code

Status: RESOLVED WORKSFORME

(Toolkit :: View Source, defect)

Description

[Paul Silaghi, QA [:pauly]]

STR:
1. Open in Firefox the test case from bug 713810: https://bugzilla.mozilla.org/attachment.cgi?id=584543
2. "Select All" and then "View Selection Source"

Actual results:
Extra code in one div:
<div style="height: 2em; background: none repeat scroll 0% 0% gold;"></div>

Expected results:
<div style="height:2em;background:gold"></div>

Comment 1

[Cork]

"Given a valid declaration, the 'background' property first sets all the individual background properties to their initial values, then assigns explicit values given in the declaration."

As View Selected Source generates the source from DOM (including things added through javascript), I would say that what you get is expected. But I'll leave that for someone else to decide.

Comment 2

[David E. Ross]

Here is another example of the problem.  Effectively, View Source and View Selection Source do not show the same HTML.  

The following attachments are based on my Web page at <http://www.rossde.com/internet/ASCII_mail.html>.  

I encountered this when I needed the source HTML from a small fragment of one of my Web pages.  I selected about three lines from the rendered page and then requested View Selection Source.  What I saw disturbed me because I wondered "When did I create such tag soup?"  It turned out that the tag soup was generated by View Selection Source and not by me; my actual HTML page did not contain any of that mess.

Comment 3

[David E. Ross]

Attachment: From context menu (1) Select All and then (2) View Selection Source

This shows inserted HTML tags -- especially </p> and </li> -- that are optional and quite unnecessary.

Comment 4

[David E. Ross]

Attachment: View > Page Source from menu bar

This is the same as my original HTML file.

Comment 5

[Henri Sivonen (:hsivonen)]

So View Selection Source is not even trying to view the selection source. It's viewing a serialization of the selection. Inserted </p>, </li>, etc. are as-designed. (I.e. not a bug.)

Whether serializing the style attribute from CSSOM instead of the DOM is a bug I'm not quite sure of.

Comment 6

[Henri Sivonen (:hsivonen)]

In looks like the case from comment 0 has been fixed.