731363 - manifest with UTF8 BOM results in ValueError("No JSON object could be decoded")

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Kumar McMillan [:kumar]]

http://arecibo1.dmz.phx1.mozilla.com/view/1531716/

  File "/data/www/addons.mozilla.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/addons.mozilla.org/zamboni/apps/amo/decorators.py", line 112, in wrapper
    return f(*args, **kw)

  File "/data/www/addons.mozilla.org/zamboni/apps/amo/decorators.py", line 104, in wrapper
    return f(*args, **kw)

  File "/data/www/addons.mozilla.org/zamboni/apps/amo/decorators.py", line 29, in wrapper
    return func(request, *args, **kw)

  File "/data/www/addons.mozilla.org/zamboni/mkt/submit/decorators.py", line 19, in wrapper
    return f(request, *args, **kw)

  File "/data/www/addons.mozilla.org/zamboni/mkt/submit/views.py", line 73, in manifest
    if addon.has_icon_in_manifest():

  File "/data/www/addons.mozilla.org/zamboni/apps/webapps/models.py", line 135, in has_icon_in_manifest
    data = self.get_manifest_json()

  File "/data/www/addons.mozilla.org/zamboni/apps/webapps/models.py", line 143, in get_manifest_json
    return json.load(mf)

  File "/usr/lib64/python2.6/json/__init__.py", line 267, in load
    parse_constant=parse_constant, **kw)

  File "/usr/lib64/python2.6/json/__init__.py", line 307, in loads
    return _default_decoder.decode(s)

  File "/usr/lib64/python2.6/json/decoder.py", line 319, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())

  File "/usr/lib64/python2.6/json/decoder.py", line 338, in raw_decode
    raise ValueError("No JSON object could be decoded")

Comment 1

[Kumar McMillan [:kumar]]

Fixed https://github.com/mozilla/zamboni/commit/ec2deed

Comment 2

[Kumar McMillan [:kumar]]

Uploading this manifest would reproduce the traceback: http://people.mozilla.com/~kmcmillan/utf8bom.webapp

Comment 3

[krupa raj[:krupa]]

Uploading the manifest from comment 2 doesn't generate any errors anymore. Verified fixed at https://marketplace-dev.allizom.org/en-US/developers/upload/dadba09bbb8b43c68e32b1993fae667f

I'm marking this as fixed.