731380 - MozillaSuiteTest shows hundreds of failures due to missing LiveConnect test cases

Status: RESOLVED INACTIVE

(Rhino Graveyard :: Core, defect)

Description

[André Bargull [:anba]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120215223356

Steps to reproduce:

Started the test ant-target with
> ant junit-all -Dno-xmlbeans=true -Dtest.library.dir="D:/git/jstests/js/src/tests"

Where "D:/git/jstests/js/src/tests" points to a local directory containing the latest jstests sources.


Actual results:

All LiveConnect test cases fail due to missing test case files. "jstests.jar" has been removed in bug 713756!

Comment 1

[Hannes Wallnoefer]

I guess I never noticed that because I still have an old version of the Mozilla test suite checked out from CVS. How should we handle this? Bundle our own copy of the test suite with Rhino and synch with mozilla-central periodically?

Comment 2

[André Bargull [:anba]]

I've pushed an up-to-date implementation to handle the current test-case format to my github repo at [1]. This will disable the o.m.j.tests.MozillaTestSuite test-suite in favour of the newly created o.m.j.tests.MozillaTestSuite2 suite (yep, I was a bit unimaginative when naming the class...). The Mozilla test suite no longer contains any LiveConnect tests [2], is it important to run those tests in Rhino? If thats the case, we may want to (need to?) run the new Mozilla test suite as well as the old version from the CVS. 


[1] https://github.com/anba/rhino/commits/bug731380
[2] https://github.com/mozilla/mozilla-central/tree/master/js/src/tests

Comment 3

[André Bargull [:anba]]

Hmm, do you think it'd make sense to file additional bug reports for each of the other patches I've made in that linked branch in my repo? Well, apart from bug 757410 which I've just created because it's 1. a VerifierError and 2. not as trivial as the other ones.

BTW, LiveConnect was removed about three years ago in the Firefox code base (bug 442399), so the tests are likely to be out-dated by now.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Closing. Bug management is now done here:
https://github.com/mozilla/rhino